Bug 53874 - [Qt] Clear page's groupName even when not in DRT
Summary: [Qt] Clear page's groupName even when not in DRT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Robert Hogan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-06 08:07 PST by Robert Hogan
Modified: 2011-02-06 10:46 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.61 KB, patch)
2011-02-06 08:09 PST, Robert Hogan 		kling: review+
kling: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2011-02-06 08:07:29 PST 
[Qt] Clear page's groupName even when not in DRT
Comment 1 Robert Hogan 2011-02-06 08:09:00 PST 
Created attachment 81405 [details]
Patch
Comment 2 Andreas Kling 2011-02-06 08:37:35 PST 
Comment on attachment 81405 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81405&action=review

r=me

> Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:310
> +    m_webPage->d->page->setGroupName(QString());

Use String() instead of QString() here to avoid the extra implicit conversion.
Comment 3 Robert Hogan 2011-02-06 10:19:30 PST 
Committed r77772: <http://trac.webkit.org/changeset/77772>
Comment 4 WebKit Review Bot 2011-02-06 10:46:48 PST 
http://trac.webkit.org/changeset/77772 might have broken Qt Linux Release
The following tests are not passing:
http/tests/websocket/tests/websocket-pending-activity.html