RESOLVED FIXED 53871
Refactor Font::normalizeSpaces() to avoid an extra String copy. 
https://bugs.webkit.org/show_bug.cgi?id=53871
Summary Refactor Font::normalizeSpaces() to avoid an extra String copy.
Andreas Kling
Reported 2011-02-06 07:23:41 PST
Font::normalizeSpaces() could take an UChar*/length pair as arguments instead of a String. All call sites create a temporary String for passing to this function, and there is some cleverness in normalizeSpaces() to reuse that String if no spaces are normalized. We should let normalizeSpaces() do the String creation which means we'll always make 1 String instead of 1 in the best case and 2 in the worst case.
Attachments
Proposed patch (7.71 KB, patch)
2011-02-06 07:24 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-02-06 07:24:48 PST
Created attachment 81402 [details] Proposed patch
Dirk Schulze
Comment 2 2011-02-06 08:17:49 PST
Comment on attachment 81402 [details] Proposed patch r=me
Andreas Kling
Comment 3 2011-02-06 08:22:31 PST
Comment on attachment 81402 [details] Proposed patch Clearing flags on attachment: 81402 Committed r77768: <http://trac.webkit.org/changeset/77768>
Andreas Kling
Comment 4 2011-02-06 08:22:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.