Bug 53866 - [chromium] Remove unused "external" case from PopupMenuChromium
Summary: [chromium] Remove unused "external" case from PopupMenuChromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-05 23:34 PST by Jay Civelli
Modified: 2011-02-07 22:46 PST (History)
2 users (show)

See Also:


Attachments
Patch (4.38 KB, patch)
2011-02-05 23:43 PST, Jay Civelli
no flags Details | Formatted Diff | Diff
Patch for landing (4.38 KB, patch)
2011-02-07 13:01 PST, Jay Civelli
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jay Civelli 2011-02-05 23:34:59 PST
In the PopupMenuChromium.[h,cpp] files, we still have the code for the "external" case, which was used previously on the Mac.
That code is not used anymore (see https://bugs.webkit.org/show_bug.cgi?id=46016) and should be removed.
Comment 1 Jay Civelli 2011-02-05 23:43:36 PST
Created attachment 81392 [details]
Patch
Comment 2 Jay Civelli 2011-02-07 13:01:33 PST
Created attachment 81510 [details]
Patch for landing
Comment 3 WebKit Commit Bot 2011-02-07 22:46:03 PST
Comment on attachment 81510 [details]
Patch for landing

Clearing flags on attachment: 81510

Committed r77904: <http://trac.webkit.org/changeset/77904>
Comment 4 WebKit Commit Bot 2011-02-07 22:46:09 PST
All reviewed patches have been landed.  Closing bug.