Bug 53845 - Add performance tests for URL parsing
Summary: Add performance tests for URL parsing
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
Depends on:
Reported: 2011-02-05 02:54 PST by Eric Seidel (no email)
Modified: 2011-02-05 03:25 PST (History)
1 user (show)

See Also:

Patch (2.48 KB, patch)
2011-02-05 03:10 PST, Eric Seidel (no email)
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-02-05 02:54:56 PST
Add performance tests for URL parsing
Comment 1 Eric Seidel (no email) 2011-02-05 03:08:53 PST
I'm omitting the urls file from the uploaded patch since it's too big. :(
Comment 2 Eric Seidel (no email) 2011-02-05 03:10:14 PST
Created attachment 81352 [details]
Comment 3 Eric Seidel (no email) 2011-02-05 03:13:50 PST
Committed r77739: <http://trac.webkit.org/changeset/77739>
Comment 4 Eric Seidel (no email) 2011-02-05 03:22:36 PST
Some figures:

We call KURL::parse() about 2000 times when loading gmail.com (a logged in account).

Since our benchmark parses apple.com 200000 times in under 400ms, it seems URL parsing is not a huge perf concern at the moment.
Comment 5 Eric Seidel (no email) 2011-02-05 03:23:49 PST
Based on those numbers, we're spending about 4ms in URL parsing while loading gmail (that's a very rough estimate).
Comment 6 Eric Seidel (no email) 2011-02-05 03:25:07 PST
Or using the figures from the english url corpus, a rough estimate of time spent loading gmail parsing urls would be 6.5 ms.  In either case, these are not huge numbers.