RESOLVED FIXED 53845
Add performance tests for URL parsing 
https://bugs.webkit.org/show_bug.cgi?id=53845
Summary Add performance tests for URL parsing
Eric Seidel (no email)
Reported 2011-02-05 02:54:56 PST
Add performance tests for URL parsing
Attachments
Patch (2.48 KB, patch)
2011-02-05 03:10 PST, Eric Seidel (no email) 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-02-05 03:08:53 PST
I'm omitting the urls file from the uploaded patch since it's too big. :(
Eric Seidel (no email)
Comment 2 2011-02-05 03:10:14 PST
Created attachment 81352 [details] Patch
Eric Seidel (no email)
Comment 3 2011-02-05 03:13:50 PST
Committed r77739: <http://trac.webkit.org/changeset/77739>
Eric Seidel (no email)
Comment 4 2011-02-05 03:22:36 PST
Some figures: We call KURL::parse() about 2000 times when loading gmail.com (a logged in account). Since our benchmark parses apple.com 200000 times in under 400ms, it seems URL parsing is not a huge perf concern at the moment.
Eric Seidel (no email)
Comment 5 2011-02-05 03:23:49 PST
Based on those numbers, we're spending about 4ms in URL parsing while loading gmail (that's a very rough estimate).
Eric Seidel (no email)
Comment 6 2011-02-05 03:25:07 PST
Or using the figures from the english url corpus, a rough estimate of time spent loading gmail parsing urls would be 6.5 ms. In either case, these are not huge numbers.
Note You need to log in before you can comment on or make changes to this bug.