Bug 53842 – WAI-ARIA @aria-sort not exposed on rowheader and columnheader roles

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

WAI-ARIA @aria-sort not exposed on rowheader and column header roles

Cocoa table headers are exposed as AXSortButtons, and ARIA table headers are cells. However, ARIA row and col headers can contain an aria-sort attribute with the following values for:

AXSortDirection: AXAscendingSortDirection | AXDescendingSortDirection

[chris fleizach]

*** Bug 53876 has been marked as a duplicate of this bug. ***

[chris fleizach]

Created attachment 81448 [details]
Patch

[Darin Adler]

Comment on attachment 81448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81448&action=review

> Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm:1990
> +        switch (m_object->sortDirection()) {
> +            case SortDirectionAscending:
> +                return NSAccessibilityAscendingSortDirectionValue;
> +            case SortDirectionDescending:
> +                return NSAccessibilityDescendingSortDirectionValue;
> +            default:
> +                return NSAccessibilityUnknownSortDirectionValue;
> +        }

WebKit style doesn't indent the case inside the switch.

[chris fleizach]

Comment on attachment 81448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81448&action=review

thanks for the review

>> Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm:1990
>> +        }
> 
> WebKit style doesn't indent the case inside the switch.

strange that the style bot didn't catch this one

[chris fleizach]

http://trac.webkit.org/changeset/77820

[James Craig]

See also: 
Bug 118511: AX: WebKit doesn't map aria-sort=other