Bug 53839 - nrwt multiprocessing: remove obsolete WatchableThread class
Summary: nrwt multiprocessing: remove obsolete WatchableThread class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks: 53838
  Show dependency tree / graph
 
Reported: 2011-02-04 20:08 PST by Dirk Pranke
Modified: 2011-02-08 16:37 PST (History)
5 users (show)

See Also:

Attachments
remove WatchableThread (4.92 KB, patch)
2011-02-04 20:10 PST, Dirk Pranke 		ojan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-02-04 20:08:41 PST 
nrwt multiprocessing: remove obsolete WatchableThread class
Comment 1 Dirk Pranke 2011-02-04 20:10:03 PST 
Created attachment 81341 [details]
remove WatchableThread
Comment 2 Eric Seidel (no email) 2011-02-05 01:17:59 PST 
Comment on attachment 81341 [details]
remove WatchableThread

I'm not sure why inlining this class is better.
Comment 3 Dirk Pranke 2011-02-05 11:59:10 PST 
fewer lines of code, less distractions. The test code that used the WatchableThread abstraction is gone, so readers might look at this code and be puzzled by why it doesn't seem to be used anywhere. And they'd be right. 

If you look at the next series of patches, my goal is to move all of the real logic into single_test_runner, leaving dump_render_tree_thread.py (and worker.py) with just the communications code.
Comment 4 Ojan Vafai 2011-02-06 14:49:38 PST 
Comment on attachment 81341 [details]
remove WatchableThread

Less subclassing seems better if we don't get anything from the subclassing.
Comment 5 Dirk Pranke 2011-02-08 16:37:31 PST 
Committed r77991: <http://trac.webkit.org/changeset/77991>