WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 53826
react-to-vsprops-changes.py doesn't force precompiled headers to be rebuilt, but should
https://bugs.webkit.org/show_bug.cgi?id=53826
Summary
react-to-vsprops-changes.py doesn't force precompiled headers to be rebuilt, ...
Adam Roben (:aroben)
Reported
2011-02-04 17:08:55 PST
r77677
made a change to common.vsprops that required a clean build to be performed. react-to-vsprops-changes.py noticed the change and touched wtf/Platform.h like it is supposed to. But the build failed anyway because precompiled headers didn't get rebuilt. It looks like we need to make react-to-vsprops-changes.py more aggressive in forcing a rebuild. Perhaps we should touch the precompiled headers themselves, or delete their compiled versions.
Attachments
Delete precompiled headers whenever any .vsprops file changes
(4.72 KB, patch)
2011-02-07 07:36 PST
,
Adam Roben (:aroben)
ddkilzer
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1
2011-02-07 07:36:56 PST
Created
attachment 81470
[details]
Delete precompiled headers whenever any .vsprops file changes
David Kilzer (:ddkilzer)
Comment 2
2011-02-07 07:45:36 PST
Comment on
attachment 81470
[details]
Delete precompiled headers whenever any .vsprops file changes r=me
Adam Roben (:aroben)
Comment 3
2011-02-07 08:04:24 PST
Committed
r77815
: <
http://trac.webkit.org/changeset/77815
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug