Bug 53811 – Null deref in DOMURL

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Cris Neckar]

Just fixing a null deref in DOMURL when the script execution context doesn't exist at the time of creation. I'll post a patch in a minute.

[Cris Neckar]

Created attachment 81304 [details]
Patch

[Jian Li]

Comment on attachment 81304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81304&action=review

> Source/WebCore/ChangeLog:5
> +        fix null deref in DOMURL

Please capitalize the 1st character.

> LayoutTests/ChangeLog:9
> +        * fast/dom/domurl-script-execution-context-crash.html: Added.

Since DOMURL is only used for blob URL, I think we'd better put this new test under fast/files.

> LayoutTests/fast/dom/domurl-script-execution-context-crash.html:6
> +        e.apply(w,['webkitURL']);

Please add a space after comma.

> LayoutTests/fast/dom/domurl-script-execution-context-crash.html:16
> +    setTimeout(crash,30);

ditto.

> LayoutTests/fast/dom/domurl-script-execution-context-crash.html:26
> +e=(w=open()).eval;

Please add space before and after 2 "=" operators.

[Cris Neckar]

Created attachment 81547 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 81547 [details]:

inspector/debugger-scripts.html bug 53982 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 81547 [details]
Patch

Clearing flags on attachment: 81547

Committed r77914: <http://trac.webkit.org/changeset/77914>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.