RESOLVED FIXED53808
GCC compiler on ARM compile fix has issues. 
https://bugs.webkit.org/show_bug.cgi?id=53808
Summary GCC compiler on ARM compile fix has issues.
David Levin
Reported 2011-02-04 13:46:53 PST
1. The define isn't specific enough. 2. The code is stuck forever. How will we know when it can be removed?
Attachments
Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-02-04 13:57:01 PST
You're a good man, señior levin. But I wouldn't kill yourself over this fix. I look forward to the review!
Dimitri Glazkov (Google)
Comment 2 2011-02-24 10:28:12 PST
(In reply to comment #0) > 1. The define isn't specific enough. I can tighten up the define using GCC_VERSION_AT_LEAST. > 2. The code is stuck forever. How will we know when it can be removed? I scoured gcc.gnu.org/bugzilla. Nothing sticks out. It also appears our cross-compiler on the ARM bot is quite old, so we should update it and see if it's gone away.
David Levin
Comment 3 2011-04-14 11:43:45 PDT
I think the gcc arm compiler has been upgraded (during abarth's stint as gardener) and likely gotten rid of this issue. Perhaps it is time to remove the code added in 53620.
David Levin
Comment 4 2011-04-15 11:56:19 PDT
This compiler fix appears to have been removed as part of http://trac.webkit.org/changeset/80463 so the issue is fixed now.
Note You need to log in before you can comment on or make changes to this bug.