Bug 53805 - WebKit2 on Windows should use DrawingAreaProxyImpl
Summary: WebKit2 on Windows should use DrawingAreaProxyImpl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords: InRadar, PlatformOnly
Depends on: 53875 53878 53879 54123 54141 54142 54145
Blocks: 45567 53877
  Show dependency tree / graph
 
Reported: 2011-02-04 13:10 PST by Adam Roben (:aroben)
Modified: 2011-02-12 08:03 PST (History)
1 user (show)

See Also:

Attachments
Make it possible to use DrawingAreaProxyImpl on Windows (10.82 KB, patch)
2011-02-06 08:56 PST, Adam Roben (:aroben) 		no flags Details | Formatted Diff | Diff
Turn on the new drawing area on Windows (1.57 KB, patch)
2011-02-09 14:36 PST, Adam Roben (:aroben) 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-02-04 13:10:31 PST 
Now that WebKit2 on Mac has switched over to DrawingAreaProxyImpl, we should switch on Windows, too.

Anders says we need to:

1) Implement BackingStoreWin - should be simple, probably just need a DIB or something
2) change the implementation of PageClient::createDrawingAreaProxy to return a new DrawingAreaProxyImpl
3) remove a bunch of #if !PLATFORM(MAC) #error directives
4) Change WebView::onPaintEvent/WebView::onPrintClientEvent to paint the way -[WKView drawRect:] does
Comment 1 Adam Roben (:aroben) 2011-02-04 13:11:01 PST 
<rdar://problem/8960666>
Comment 2 Adam Roben (:aroben) 2011-02-06 08:56:28 PST 
Created attachment 81410 [details]
Make it possible to use DrawingAreaProxyImpl on Windows
Comment 3 Adam Roben (:aroben) 2011-02-06 09:00:09 PST 
Comment on attachment 81410 [details]
Make it possible to use DrawingAreaProxyImpl on Windows

Whoops, wrong bug!
Comment 4 Adam Roben (:aroben) 2011-02-07 13:21:19 PST 
Committed r77839: <http://trac.webkit.org/changeset/77839>
Comment 5 Adam Roben (:aroben) 2011-02-07 13:21:52 PST 
(In reply to comment #4)
> Committed r77839: <http://trac.webkit.org/changeset/77839>

Whoops, wrong bug!
Comment 6 Adam Roben (:aroben) 2011-02-09 14:36:25 PST 
Created attachment 81877 [details]
Turn on the new drawing area on Windows
Comment 7 Adam Roben (:aroben) 2011-02-10 04:43:40 PST 
Committed r78201: <http://trac.webkit.org/changeset/78201>