Assertion failure in WebInspectorProxy::platformClose closing main window when inspecting a popup window, or when running regression tests

[Brian Weinstein]

Assertion failure in WebInspectorProxy::platformClose closing main window when inspecting a popup window, or when running regression tests.


>    WebKit.dll!WebKit::WebInspectorProxy::platformClose()  Line 174 + 0x25 bytes    C++
    WebKit.dll!WebKit::WebInspectorProxy::invalidate()  Line 74    C++
    WebKit.dll!WebKit::WebPageProxy::close()  Line 240    C++
    WebKit.dll!WKPageClose(const OpaqueWKPage * pageRef=0x061f0f58)  Line 103    C++

ASSERT(m_inspectorWindow) is the failing assertion.

<rdar://problem/8814364>

[Brian Weinstein]

Created attachment 81264 [details]
[PATCH] Fix

[Adam Roben (:aroben)]

Comment on attachment 81264 [details]
[PATCH] Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=81264&action=review

> Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:178
> +    if (m_isVisible) {
> +        ASSERT(m_inspectorWindow);
> +        ASSERT(m_inspectorView);
> +    }

To get rid of the if in Release builds, you could do:

ASSERT(!m_isVisible || m_inspectorWindow);
ASSERT(!m_isVisible || m_inspectorView);

> Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:181
> +        ASSERT(::IsWindow(m_inspectorWindow));

Have you verified that this is true even when the inspector is docked?

[Brian Weinstein]

(In reply to comment #2)
> (From update of attachment 81264 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=81264&action=review
> 
> > Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:178
> > +    if (m_isVisible) {
> > +        ASSERT(m_inspectorWindow);
> > +        ASSERT(m_inspectorView);
> > +    }
> 
> To get rid of the if in Release builds, you could do:
> 
> ASSERT(!m_isVisible || m_inspectorWindow);
> ASSERT(!m_isVisible || m_inspectorView);

Fixed.

> 
> > Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:181
> > +        ASSERT(::IsWindow(m_inspectorWindow));
> 
> Have you verified that this is true even when the inspector is docked?

We don't support a docked inspector in WebKit2 yet, but I will make sure to check this when we do.

Thanks!

[Brian Weinstein]

Landed in r77655.