Bug 53797 – [GTK] WebKitWebFrame can return a stale frame name when calling webkit_web_frame_get_name

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Robinson]

If you call webkit_web_frame_get_name more than once with the same WebKitWebFrame*, it can return a stale frame name if the name changes between the calls. This can be observed by the failure of fast/history/history-subframe-with-name.html.

[Martin Robinson]

Sorry, the failing test should be: fast/events/pageshow-pagehide-on-back-uncached.html. The previously mentioned test is failing for some other reason and that failure is tracked in 44784.

[Martin Robinson]

Created attachment 81265 [details]
Patch for this issue

[Martin Robinson]

I have attached a patch fixing this issue.

[Martin Robinson]

Comment on attachment 81265 [details]
Patch for this issue

View in context: https://bugs.webkit.org/attachment.cgi?id=81265&action=review

> LayoutTests/platform/gtk/Skipped:4728
> -fast/events/pagehide-timeout.html
>  \ No newline at end of file
> +fast/events/pagehide-timeout.html

This change is an accent from my editing, I think. I'll omit it when landing.

[Xan Lopez]

Comment on attachment 81265 [details]
Patch for this issue

View in context: https://bugs.webkit.org/attachment.cgi?id=81265&action=review

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:487
>  

I guess we should return "" here to not break the API subtly. It does not make much sense, though...

[Martin Robinson]

Committed r77714: <http://trac.webkit.org/changeset/77714>

[Martin Robinson]

Comment on attachment 81265 [details]
Patch for this issue

Landed with Xan's suggestions.