Bug 53797 - [GTK] WebKitWebFrame can return a stale frame name when calling webkit_web_frame_get_name
Summary: [GTK] WebKitWebFrame can return a stale frame name when calling webkit_web_fr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-02-04 12:20 PST by Martin Robinson
Modified: 2011-02-04 18:14 PST (History)
2 users (show)

See Also:

Attachments
Patch for this issue (3.98 KB, patch)
2011-02-04 12:28 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2011-02-04 12:20:14 PST 
If you call webkit_web_frame_get_name more than once with the same WebKitWebFrame*, it can return a stale frame name if the name changes between the calls. This can be observed by the failure of fast/history/history-subframe-with-name.html.
Comment 1 Martin Robinson 2011-02-04 12:23:11 PST 
Sorry, the failing test should be: fast/events/pageshow-pagehide-on-back-uncached.html. The previously mentioned test is failing for some other reason and that failure is tracked in 44784.
Comment 2 Martin Robinson 2011-02-04 12:28:05 PST 
Created attachment 81265 [details]
Patch for this issue
Comment 3 Martin Robinson 2011-02-04 12:28:51 PST 
I have attached a patch fixing this issue.
Comment 4 Martin Robinson 2011-02-04 17:14:37 PST 
Comment on attachment 81265 [details]
Patch for this issue

View in context: https://bugs.webkit.org/attachment.cgi?id=81265&action=review

> LayoutTests/platform/gtk/Skipped:4728
> -fast/events/pagehide-timeout.html
>  \ No newline at end of file
> +fast/events/pagehide-timeout.html

This change is an accent from my editing, I think. I'll omit it when landing.
Comment 5 Xan Lopez 2011-02-04 17:27:16 PST 
Comment on attachment 81265 [details]
Patch for this issue

View in context: https://bugs.webkit.org/attachment.cgi?id=81265&action=review

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:487
>  

I guess we should return "" here to not break the API subtly. It does not make much sense, though...
Comment 6 Martin Robinson 2011-02-04 18:13:17 PST 
Committed r77714: <http://trac.webkit.org/changeset/77714>
Comment 7 Martin Robinson 2011-02-04 18:14:00 PST 
Comment on attachment 81265 [details]
Patch for this issue

Landed with Xan's suggestions.