Bug 53759 - Changed MarkedSpace to delegate grow/shrink decisions to Heap
Summary: Changed MarkedSpace to delegate grow/shrink decisions to Heap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-03 23:18 PST by Geoffrey Garen
Modified: 2011-02-04 16:20 PST (History)
5 users (show)

See Also:


Attachments
Patch (5.49 KB, patch)
2011-02-03 23:27 PST, Geoffrey Garen
no flags Details | Formatted Diff | Diff
Patch (5.31 KB, patch)
2011-02-04 15:11 PST, Geoffrey Garen
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-02-03 23:18:44 PST
Changed MarkedSpace to delegate grow/shrink decisions to Heap
Comment 1 Geoffrey Garen 2011-02-03 23:27:09 PST
Created attachment 81193 [details]
Patch
Comment 2 Geoffrey Garen 2011-02-03 23:41:40 PST
Committed r77612: <http://trac.webkit.org/changeset/77612>
Comment 3 WebKit Review Bot 2011-02-04 02:43:36 PST
http://trac.webkit.org/changeset/77612 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
accessibility/aria-activedescendant-crash.html
accessibility/aria-checkbox-checked.html
accessibility/aria-checkbox-text.html
accessibility/aria-combobox.html
accessibility/aria-controls-with-tabs.html
Comment 4 Nikolas Zimmermann 2011-02-04 04:59:22 PST
Reopening bug. I see sporadic assertions on both 10.5 and 10.6. An example:

ASSERTION FAILED: m_heap.usedBlocks > neededBlocks
(/Users/nikolaszimmermann/Coding/WebKit/Source/JavaScriptCore/runtime/MarkedSpace.cpp:174 void JSC::MarkedSpace::shrinkBlocks(size_t))
 -> JSC::MarkedSpace::shrinkBlocks(unsigned long)
 -> JSC::MarkedSpace::sweep()
 -> JSC::Heap::reset(JSC::Heap::SweepToggle)
 -> JSC::Heap::collectAllGarbage()
 -> JSC::DefaultGCActivityCallbackPlatformData::trigger(__CFRunLoopTimer*, void*)
 -> __CFRunLoopRun
 -> CFRunLoopRunSpecific
 -> RunCurrentEventLoopInMode
 -> ReceiveNextEventCommon
 -> BlockUntilNextEventMatchingListInMode
 -> _DPSNextEvent
 -> -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:]
 -> 0x1000162f4
 -> -[NSApplication run]
 -> NSApplicationMain
 -> 0x10000a1c0

SL bot crashes all tests as well.
Comment 5 Ilya Tikhonovsky 2011-02-04 05:04:28 PST
rolled out 


Committed r77619
	M	Source/JavaScriptCore/runtime/MarkedSpace.cpp
	M	Source/JavaScriptCore/runtime/Heap.cpp
	M	Source/JavaScriptCore/runtime/Heap.h
	M	Source/JavaScriptCore/runtime/MarkedSpace.h
	M	Source/JavaScriptCore/ChangeLog
r77619 = c436d330dbed26b8ba04af3f59c77705e7cf3d42 (refs/remotes/trunk)
Comment 6 Geoffrey Garen 2011-02-04 15:11:48 PST
Created attachment 81301 [details]
Patch
Comment 7 Oliver Hunt 2011-02-04 15:12:40 PST
Comment on attachment 81301 [details]
Patch

r=me
Comment 8 Geoffrey Garen 2011-02-04 16:20:21 PST
Committed r77699: <http://trac.webkit.org/changeset/77699>