Bug 53745 - Remove unneeded function declarations in comments in EditorClient.h
Summary: Remove unneeded function declarations in comments in EditorClient.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Trivial
Assignee: Nobody
URL: http://trac.webkit.org/browser/trunk/...
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-03 17:48 PST by Levi Weintraub
Modified: 2011-02-04 11:58 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.86 KB, patch)
2011-02-04 11:26 PST, Levi Weintraub 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2011-02-03 17:48:37 PST 
EditorClient.h contains 5 functions that were commented out over 4 years ago, and three of which reference NS_____ objects. Unless anyone objects I'll clean them up. They don't appear to have references in WebKit at all.

CC-ing from svn blame.
Comment 1 Darin Adler 2011-02-04 09:44:44 PST 
It’s fine to remove these functions.

It’s not quite right to say they were “commented out 4 years ago”. They have always been commented out!

See <http://trac.webkit.org/browser/trunk/WebCore/bridge/EditorClient.h?rev=17179> for the initial version of the file.
Comment 2 Levi Weintraub 2011-02-04 11:26:50 PST 
Created attachment 81252 [details]
Patch
Comment 3 Levi Weintraub 2011-02-04 11:58:02 PST 
Committed r77651: <http://trac.webkit.org/changeset/77651>