WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
53745
Remove unneeded function declarations in comments in EditorClient.h
https://bugs.webkit.org/show_bug.cgi?id=53745
Summary
Remove unneeded function declarations in comments in EditorClient.h
Levi Weintraub
Reported
2011-02-03 17:48:37 PST
EditorClient.h contains 5 functions that were commented out over 4 years ago, and three of which reference NS_____ objects. Unless anyone objects I'll clean them up. They don't appear to have references in WebKit at all. CC-ing from svn blame.
Attachments
Patch
(1.86 KB, patch)
2011-02-04 11:26 PST
,
Levi Weintraub
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2011-02-04 09:44:44 PST
It’s fine to remove these functions. It’s not quite right to say they were “commented out 4 years ago”. They have always been commented out! See <
http://trac.webkit.org/browser/trunk/WebCore/bridge/EditorClient.h?rev=17179
> for the initial version of the file.
Levi Weintraub
Comment 2
2011-02-04 11:26:50 PST
Created
attachment 81252
[details]
Patch
Levi Weintraub
Comment 3
2011-02-04 11:58:02 PST
Committed
r77651
: <
http://trac.webkit.org/changeset/77651
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug