Bug 53720 – new-run-webkit-tests: fix normalization of paths on windows when gathering files

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

new-run-webkit-tests: fix normalization of paths on windows when gathering files

[Dirk Pranke]

Created attachment 81122 [details]
Patch

[Mihai Parparita]

Comment on attachment 81122 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81122&action=review

> Tools/Scripts/webkitpy/layout_tests/port/test_files.py:66
> +def normalize(fs, base_dir, paths):

Nit: Consistent naming for Filesystem parameters (filesystem vs. fs) seems like a good idea.

> Tools/Scripts/webkitpy/layout_tests/port/test_files_unittest.py:91
> +        # results that we get in test_forward_subpath().

Did you mean to say test_mocked_win here?

[Dirk Pranke]

(In reply to comment #2)
> (From update of attachment 81122 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=81122&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/port/test_files.py:66
> > +def normalize(fs, base_dir, paths):
> 
> Nit: Consistent naming for Filesystem parameters (filesystem vs. fs) seems like a good idea.
> 

Yeah, will fix.

> > Tools/Scripts/webkitpy/layout_tests/port/test_files_unittest.py:91
> > +        # results that we get in test_forward_subpath().
> 
> Did you mean to say test_mocked_win here?

Yup. I changed the name but not the comment.

Thanks for the review!

[Dirk Pranke]

Committed r77550: <http://trac.webkit.org/changeset/77550>

[Dirk Pranke]

Committed r77556: <http://trac.webkit.org/changeset/77556>

[WebKit Review Bot]

http://trac.webkit.org/changeset/77556 might have broken GTK Linux 32-bit Debug
The following tests are not passing:
fast/events/pagehide-timeout.html