Bug 53720 - new-run-webkit-tests: fix normalization of paths on windows when gathering files
Summary: new-run-webkit-tests: fix normalization of paths on windows when gathering files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-03 15:09 PST by Dirk Pranke
Modified: 2011-02-04 02:40 PST (History)
6 users (show)

See Also:

Attachments
Patch (8.70 KB, patch)
2011-02-03 15:15 PST, Dirk Pranke 		mihaip: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-02-03 15:09:52 PST 
new-run-webkit-tests: fix normalization of paths on windows when gathering files
Comment 1 Dirk Pranke 2011-02-03 15:15:00 PST 
Created attachment 81122 [details]
Patch
Comment 2 Mihai Parparita 2011-02-03 15:38:22 PST 
Comment on attachment 81122 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81122&action=review

> Tools/Scripts/webkitpy/layout_tests/port/test_files.py:66
> +def normalize(fs, base_dir, paths):

Nit: Consistent naming for Filesystem parameters (filesystem vs. fs) seems like a good idea.

> Tools/Scripts/webkitpy/layout_tests/port/test_files_unittest.py:91
> +        # results that we get in test_forward_subpath().

Did you mean to say test_mocked_win here?
Comment 3 Dirk Pranke 2011-02-03 15:45:25 PST 
(In reply to comment #2)
> (From update of attachment 81122 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=81122&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/port/test_files.py:66
> > +def normalize(fs, base_dir, paths):
> 
> Nit: Consistent naming for Filesystem parameters (filesystem vs. fs) seems like a good idea.
> 

Yeah, will fix.

> > Tools/Scripts/webkitpy/layout_tests/port/test_files_unittest.py:91
> > +        # results that we get in test_forward_subpath().
> 
> Did you mean to say test_mocked_win here?

Yup. I changed the name but not the comment.

Thanks for the review!
Comment 4 Dirk Pranke 2011-02-03 16:13:55 PST 
Committed r77550: <http://trac.webkit.org/changeset/77550>
Comment 5 Dirk Pranke 2011-02-03 16:18:37 PST 
Committed r77556: <http://trac.webkit.org/changeset/77556>
Comment 6 WebKit Review Bot 2011-02-04 02:40:26 PST 
http://trac.webkit.org/changeset/77556 might have broken GTK Linux 32-bit Debug
The following tests are not passing:
fast/events/pagehide-timeout.html