RESOLVED FIXED 53687
[v8] Bail out if to string conversion returned empty handle 
https://bugs.webkit.org/show_bug.cgi?id=53687
Summary [v8] Bail out if to string conversion returned empty handle
anton muhin
Reported 2011-02-03 09:33:26 PST
[v8] Bail out if to string conversion returned empty handle
Attachments
Patch (2.76 KB, patch)
2011-02-03 09:46 PST, anton muhin 		no flags
DetailsFormatted DiffDiff
Patch (2.85 KB, patch)
2011-02-03 10:24 PST, anton muhin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
anton muhin
Comment 1 2011-02-03 09:46:41 PST
Created attachment 81071 [details] Patch
Adam Barth
Comment 2 2011-02-03 10:16:49 PST
Comment on attachment 81071 [details] Patch Generally speaking, we'd rather fix the root cause of the issue that bandaid over it like this. Maybe add an ASSERT_NOT_REACHED to emphasize that it shouldn't happen? Ideally we'd remove this code once we fixed the underlying bug...
anton muhin
Comment 3 2011-02-03 10:24:16 PST
Created attachment 81076 [details] Patch
anton muhin
Comment 4 2011-02-03 10:26:02 PST
(In reply to comment #2) > (From update of attachment 81071 [details]) > Generally speaking, we'd rather fix the root cause of the issue that bandaid over it like this. Maybe add an ASSERT_NOT_REACHED to emphasize that it shouldn't happen? Ideally we'd remove this code once we fixed the underlying bug... Definitely. I've got something which looks pretty much like a reduction for the core problem, but it's pure v8 API test. I am starting to work on it immediately. When issue in v8 is fixed, we'll run automated test with v8 patch applied and this patch removed. If things go smooth, I'll revert this patch. And ASSERT added
anton muhin
Comment 5 2011-02-03 10:28:40 PST
Comment on attachment 81076 [details] Patch Thank you again, Adam.
WebKit Commit Bot
Comment 6 2011-02-03 21:04:28 PST
Comment on attachment 81076 [details] Patch Clearing flags on attachment: 81076 Committed r77597: <http://trac.webkit.org/changeset/77597>
WebKit Commit Bot
Comment 7 2011-02-03 21:04:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.