Web Inspector: remove settings related methods from InspectorClient. All settings are now stored on the front-end side. Port-specific stuff should go into WebKit layer.
Created attachment 81069 [details] Patch
Comment on attachment 81069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81069&action=review > Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp:68 > + if (inspectorSettingName == "resourceTrackingEnabled") Nuke this? > Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp:71 > + if (inspectorSettingName == "xhrMonitor") Nuke this? > Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp:74 > + if (inspectorSettingName == "frontendSettings") Nuke this? > Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp:77 > + if (inspectorSettingName == "debuggerEnabled") Nuke this? > Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp:80 > + if (inspectorSettingName == "profilerEnabled") Nuke this? > Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp:113 > + if (key == "resourceTrackingEnabled" || key == "xhrMonitor" nuke this? > Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp:133 > + if (key == "resourceTrackingEnabled" || key == "xhrMonitor" nuke this?
Comment on attachment 81069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81069&action=review >> Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp:133 >> + if (key == "resourceTrackingEnabled" || key == "xhrMonitor" > > nuke this? I agree. Please keep platform specific code as simple as possible. too many platform specific code. Only storeSetting/populateSetting should be platform specific. I think it should be r-.
Created attachment 81195 [details] Patch Patch addressing all review comments(both by loislo and pfeldman)
Created attachment 81198 [details] Patch that I'm going to land
Committed r77617: <http://trac.webkit.org/changeset/77617>
(In reply to comment #2) > (From update of attachment 81069 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=81069&action=review > > > Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp:68 > > + if (inspectorSettingName == "resourceTrackingEnabled") > > Nuke this? Why did you guys do these changes to our Inspector Client? You broke our functionality for no good reason, it seems? Why didn't you just move the code instead of breaking it?
Can you restore our code to how it was before, just moved to its new home, please? =)