Bug 53683 - [GTK] Flaky websocket tests on 32-bits Release
Summary: [GTK] Flaky websocket tests on 32-bits Release
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 54207 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-02-03 07:18 PST by Philippe Normand
Modified: 2011-05-02 09:00 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2011-02-03 07:18:05 PST
--- /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/http/tests/websocket/tests/url-with-credential-expected.txt	2011-02-03 07:03:33.000000000 -0800
+++ /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/http/tests/websocket/tests/url-with-credential-actual.txt	2011-02-03 07:03:33.000000000 -0800
@@ -3,11 +3,8 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 url=ws://user:pass@127.0.0.1:8880/websocket/tests/echo-location
-WebSocket is open
-received:ws://127.0.0.1:8880/websocket/tests/echo-location
-WebSocket is closed
-PASS handshake_success is true
-PASS ws_location is "ws://127.0.0.1:8880/websocket/tests/echo-location"
+FAIL handshake_success should be true. Was false.
+FAIL ws_location should be ws://127.0.0.1:8880/websocket/tests/echo-location (of type string). Was undefined (of type undefined).
 PASS successfullyParsed is true
 
 TEST COMPLETE


--- /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/http/tests/websocket/tests/url-with-empty-query-expected.txt	2011-02-03 07:03:35.000000000 -0800
+++ /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/http/tests/websocket/tests/url-with-empty-query-actual.txt	2011-02-03 07:03:35.000000000 -0800
@@ -3,11 +3,8 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 url=ws://127.0.0.1:8880/websocket/tests/echo-location?
-WebSocket is open
-received:ws://127.0.0.1:8880/websocket/tests/echo-location?
-WebSocket is closed
-PASS handshake_success is true
-PASS ws_location is url
+FAIL handshake_success should be true. Was false.
+FAIL ws_location should be ws://127.0.0.1:8880/websocket/tests/echo-location? (of type string). Was undefined (of type undefined).
 PASS successfullyParsed is true
 
 TEST COMPLETE

These 2 tests, like most websocket tests use setTimeout()... It seems that in some cases the timeout expires before the socket has been set up. Will skip these 2 tests for now.
Comment 1 Philippe Normand 2011-02-03 07:22:35 PST
Skipped those 2 tests  in http://trac.webkit.org/changeset/77488
Comment 2 Philippe Normand 2011-02-03 08:19:32 PST
skip http/tests/websocket/tests/simple.html and http/tests/websocket/tests/cross-origin.html in http://trac.webkit.org/changeset/77493
Comment 3 Philippe Normand 2011-02-03 08:20:06 PST
--- /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/http/tests/websocket/tests/simple-expected.txt	2011-02-03 08:14:02.000000000 -0800
+++ /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/http/tests/websocket/tests/simple-actual.txt	2011-02-03 08:14:02.000000000 -0800
@@ -3,9 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 Created a socket to 'ws://127.0.0.1:8880/websocket/tests/simple'; readyState 0.
-Connected; readyState 1
-Received: 'Hello from Simple WSH.'; readyState 1
-Closed; readyState 2.
+Timed out in state: 0
 PASS successfullyParsed is true
 
 TEST COMPLETE
Comment 4 Philippe Normand 2011-02-10 06:57:23 PST
*** Bug 54207 has been marked as a duplicate of this bug. ***
Comment 5 Philippe Normand 2011-02-10 07:00:23 PST
Skipped them all in http://trac.webkit.org/changeset/78221
Comment 6 Eric Seidel (no email) 2011-05-01 17:44:37 PDT
Adam moved the websocket tests over to a real http server and most of the flakiness went away. If you see this again, please re-open.
Comment 7 Philippe Normand 2011-05-02 03:55:14 PDT
Committed r85469: <http://trac.webkit.org/changeset/85469>
Comment 8 Philippe Normand 2011-05-02 09:00:55 PDT
I meant r85470