Bug 53676 – fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code tests fail when showModalDialog isn't supported

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: DOM

[Adam Roben (:aroben)]

To reproduce:

1. Delete the -webViewRunModal: implementation from DumpRenderTree/mac/UIDelegate.mm
2. run-webkit-tests fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code

All the tests fail. They seem to be failing because "this.showModalDialog" exists in the eval scope but not in the non-eval scope. Why would eval() cause showModalDialog to appear?

[Adam Roben (:aroben)]

Until bug 53675 is fixed, this bug is causing these tests to fail on Windows. They were added to the Skipped file way back in r61599.

[Adam Roben (:aroben)]

<rdar://problem/8953560>

[Chang Shu]

Created attachment 97835 [details]
fix patch

It seems to me all I have to do is to hook up the runModal function.

[WebKit Review Bot]

Comment on attachment 97835 [details]
fix patch

Clearing flags on attachment: 97835

Committed r89270: <http://trac.webkit.org/changeset/89270>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Adam Roben (:aroben)]

This bug was not meant to be about the WK2-specific failures on these tests. This bug is about the fact that these tests are affected by whether the showModalDialog function exists or not. A new bug should have been filed to cover the WK2-specific failures.

[Chang Shu]

(In reply to comment #6)
> This bug was not meant to be about the WK2-specific failures on these tests. This bug is about the fact that these tests are affected by whether the showModalDialog function exists or not. A new bug should have been filed to cover the WK2-specific failures.

Right. :) Sorry for the confusion.

[Ahmad Saleem]

Tests are gone with 'https://github.com/WebKit/WebKit/commit/011fe7359898b678e31fabdc17df1ff69b910764'.

Marking this as 'RESOLVED CONFIGURATION CHANGED'.