Bug 53671 - [Qt] WebKit2 needs to support font size changing and getting default font size
Summary: [Qt] WebKit2 needs to support font size changing and getting default font size
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-02-03 04:18 PST by Juha Savolainen
Modified: 2011-03-01 08:39 PST (History)
6 users (show)

See Also:

Attachments
Added fontSize enum and methods to get/set default font sizes. (2.84 KB, patch)
2011-02-03 04:25 PST, Juha Savolainen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Juha Savolainen 2011-02-03 04:18:12 PST 
QWKPreferences should support setting/getting default font sizes.
Comment 1 Juha Savolainen 2011-02-03 04:25:59 PST 
Created attachment 81050 [details]
Added fontSize enum and methods to get/set default font sizes.
Comment 2 Andreas Kling 2011-02-03 05:51:13 PST 
Any reason we can't have the exact same API as WK1 QWebSettings setFontSize/fontSize?
Comment 3 Juha Savolainen 2011-02-03 09:26:14 PST 
(In reply to comment #2)
> Any reason we can't have the exact same API as WK1 QWebSettings setFontSize/fontSize?

Do you mean missing enum QWebSettings::MinimumLogicalFontSize? If yes, I didnt find any C-function for this and in WK1 there is the following description: The minimum logical font size that is applied when zooming out with QWebFrame::setTextSizeMultiplier(). And in WK2 we don't have frame API so that was the reason. But if I have understand something wrong or you have noticed something else, please correct me.
Comment 4 Juha Savolainen 2011-03-01 03:46:27 PST 
Andreas, could you clarify this a little?
Comment 5 Andreas Kling 2011-03-01 04:22:44 PST 
(In reply to comment #4)
> Andreas, could you clarify this a little?

Sorry, I completely forgot about this patch. It's fine as-is, r=me :)
Comment 6 WebKit Commit Bot 2011-03-01 06:13:19 PST 
Comment on attachment 81050 [details]
Added fontSize enum and methods to get/set default font sizes.

Clearing flags on attachment: 81050

Committed r79997: <http://trac.webkit.org/changeset/79997>
Comment 7 WebKit Commit Bot 2011-03-01 06:13:24 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Review Bot 2011-03-01 08:39:34 PST 
http://trac.webkit.org/changeset/79997 might have broken GTK Linux 32-bit Debug