Bug 53671 – [Qt] WebKit2 needs to support font size changing and getting default font size

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Juha Savolainen]

QWKPreferences should support setting/getting default font sizes.

[Juha Savolainen]

Created attachment 81050 [details]
Added fontSize enum and methods to get/set default font sizes.

[Andreas Kling]

Any reason we can't have the exact same API as WK1 QWebSettings setFontSize/fontSize?

[Juha Savolainen]

(In reply to comment #2)
> Any reason we can't have the exact same API as WK1 QWebSettings setFontSize/fontSize?

Do you mean missing enum QWebSettings::MinimumLogicalFontSize? If yes, I didnt find any C-function for this and in WK1 there is the following description: The minimum logical font size that is applied when zooming out with QWebFrame::setTextSizeMultiplier(). And in WK2 we don't have frame API so that was the reason. But if I have understand something wrong or you have noticed something else, please correct me.

[Juha Savolainen]

Andreas, could you clarify this a little?

[Andreas Kling]

(In reply to comment #4)
> Andreas, could you clarify this a little?

Sorry, I completely forgot about this patch. It's fine as-is, r=me :)

[WebKit Commit Bot]

Comment on attachment 81050 [details]
Added fontSize enum and methods to get/set default font sizes.

Clearing flags on attachment: 81050

Committed r79997: <http://trac.webkit.org/changeset/79997>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/79997 might have broken GTK Linux 32-bit Debug