RESOLVED FIXED 53647
[GTK] Need support for dumping focus rectangles in pixel results 
https://bugs.webkit.org/show_bug.cgi?id=53647
Summary [GTK] Need support for dumping focus rectangles in pixel results
Martin Robinson
Reported 2011-02-02 17:02:28 PST
Pixel results do not dump focus rectangles. A prime example of a test that requires this is /editing/selection/transformed-selection-rects-expected.png.
Attachments
Patch (5.01 KB, patch)
2011-04-16 03:56 PDT, Zan Dobersek 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2011-04-01 10:39:59 PDT
This test successfully passes with a release 64-bit build at revision 82691. Also the focus rectangle seems to be properly shown when running pixel tests. Are there any issues with this test in debug builds or should we try unskipping it?
Martin Robinson
Comment 2 2011-04-01 12:55:57 PDT
(In reply to comment #1) > This test successfully passes with a release 64-bit build at revision 82691. Also the focus rectangle seems to be properly shown when running pixel tests. > > Are there any issues with this test in debug builds or should we try unskipping it? I think it's still missing the red rectangle. Compare the results: a. LayoutTests/platform/gtk/editing/selection/transformed-selection-rects-expected.png b. LayoutTests/platform/mac/editing/selection/transformed-selection-rects-expected.png b. LayoutTests/platform/chromium-win/editing/selection/transformed-selection-rects-expected.png
Zan Dobersek
Comment 3 2011-04-16 03:56:21 PDT
Created attachment 89923 [details] Patch
Zan Dobersek
Comment 4 2011-04-16 04:01:16 PDT
(In reply to comment #3) > Created an attachment (id=89923) [details] > Patch This patch adds support for dumping selection rectangle. The pixel results for editing/selection/transformed-selection-rects.html now have a proper red rectangle around the area of the selection. Grepping through the LayoutTests directory, these tests seem to utilize this functionality and should have their expected pixel results regenerated: editing/selection/4402375.html editing/selection/image-before-linebreak.html editing/selection/replaced-boundaries-1.html editing/selection/replaced-boundaries-2.html editing/selection/replaced-boundaries-3.html editing/selection/transformed-selection-rects.html svg/text/foreignObject-text-clipping-bug.xml svg/text/selection-doubleclick.svg svg/text/selection-tripleclick.svg svg/text/text-align-01-b.svg svg/text/text-align-02-b.svg svg/text/text-align-03-b.svg svg/text/text-align-04-b.svg svg/text/text-align-05-b.svg svg/text/text-align-06-b.svg svg/text/text-altglyph-01-b.svg svg/text/text-deco-01-b.svg svg/text/text-fonts-01-t.svg svg/text/text-fonts-02-t.svg svg/text/text-intro-05-t.svg svg/text/text-path-01-b.svg svg/text/text-spacing-01-b.svg svg/text/text-text-01-b.svg svg/text/text-text-03-b.svg svg/text/text-text-04-t.svg svg/text/text-text-05-t.svg svg/text/text-text-06-t.svg svg/text/text-text-07-t.svg svg/text/text-text-08-b.svg svg/text/text-tref-01-b.svg svg/text/text-tselect-01-b.svg svg/text/text-tselect-02-f.svg svg/text/text-tspan-01-b.svg svg/text/text-ws-01-t.svg svg/text/text-ws-02-t.svg svg/text/textPathBoundsBug.svg
Martin Robinson
Comment 5 2011-04-18 08:45:56 PDT
Comment on attachment 89923 [details] Patch Great. I will land this and generate the results.
Martin Robinson
Comment 6 2011-04-18 20:51:28 PDT
Committed r84221: <http://trac.webkit.org/changeset/84221>
Note You need to log in before you can comment on or make changes to this bug.