Bug 53639 – Add ChromeClient function to paint custom overhang areas

• Status: RESOLVED
• Resolution: FIXED
• Component: Frames

[Sam Weinig]

Add ChromeClient function to paint custom overhang areas for the main frame.

[Sam Weinig]

Created attachment 81000 [details]
Patch

[WebKit Review Bot]

Attachment 81000 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebKit2/Shared/API/c/cg/WKGraphicsContextCG.h:36:  The parameter name "graphicsContext" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Landed in r77432.

[WebKit Review Bot]

http://trac.webkit.org/changeset/77432 might have broken SnowLeopard Intel Release (Build)

[Daniel Bates]

Comment on attachment 81000 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81000&action=review

I know this patch was already committed, but while briefly looking through it I noticed some minor issues.

> Source/WebKit2/Shared/WebGraphicsContext.cpp:8
> +/*
> + *  WebGraphicsContext.cpp
> + *  WebKit2
> + *
> + *  Created by Sam Weinig on 2/1/11.
> + *  Copyright 2011 Apple Inc. All rights reserved.
> + *
> + */

This copyright comment follows from the standard Xcode copyright template. We should be using the Apple BSD license for this file.

> Source/WebKit2/Shared/API/c/WKGraphicsContext.cpp:2
> + * Copyright (C) 2010 Apple Inc. All rights reserved.

Nit: 2010 => 2011.

> Source/WebKit2/Shared/API/c/WKGraphicsContext.h:2
> + * Copyright (C) 2010 Apple Inc. All rights reserved.

Ditto.

> Source/WebKit2/Shared/API/c/cg/WKGraphicsContextCG.cpp:2
> + * Copyright (C) 2010 Apple Inc. All rights reserved.

Ditto.