Bug 53639 - Add ChromeClient function to paint custom overhang areas
Summary: Add ChromeClient function to paint custom overhang areas
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-02 16:16 PST by Sam Weinig
Modified: 2011-02-02 21:30 PST (History)
3 users (show)

See Also:


Attachments
Patch (40.28 KB, patch)
2011-02-02 16:19 PST, Sam Weinig
bdakin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-02-02 16:16:32 PST
Add ChromeClient function to paint custom overhang areas for the main frame.
Comment 1 Sam Weinig 2011-02-02 16:19:29 PST
Created attachment 81000 [details]
Patch
Comment 2 WebKit Review Bot 2011-02-02 16:22:27 PST
Attachment 81000 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebKit2/Shared/API/c/cg/WKGraphicsContextCG.h:36:  The parameter name "graphicsContext" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2011-02-02 16:44:46 PST
Landed in r77432.
Comment 4 WebKit Review Bot 2011-02-02 17:01:26 PST
http://trac.webkit.org/changeset/77432 might have broken SnowLeopard Intel Release (Build)
Comment 5 Daniel Bates 2011-02-02 21:30:26 PST
Comment on attachment 81000 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81000&action=review

I know this patch was already committed, but while briefly looking through it I noticed some minor issues.

> Source/WebKit2/Shared/WebGraphicsContext.cpp:8
> +/*
> + *  WebGraphicsContext.cpp
> + *  WebKit2
> + *
> + *  Created by Sam Weinig on 2/1/11.
> + *  Copyright 2011 Apple Inc. All rights reserved.
> + *
> + */

This copyright comment follows from the standard Xcode copyright template. We should be using the Apple BSD license for this file.

> Source/WebKit2/Shared/API/c/WKGraphicsContext.cpp:2
> + * Copyright (C) 2010 Apple Inc. All rights reserved.

Nit: 2010 => 2011.

> Source/WebKit2/Shared/API/c/WKGraphicsContext.h:2
> + * Copyright (C) 2010 Apple Inc. All rights reserved.

Ditto.

> Source/WebKit2/Shared/API/c/cg/WKGraphicsContextCG.cpp:2
> + * Copyright (C) 2010 Apple Inc. All rights reserved.

Ditto.