Bug 53637 - [chromium] complex joining characters positioned in wrong place
Summary: [chromium] complex joining characters positioned in wrong place
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Evan Martin
URL:
Keywords:
: 41435 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-02-02 16:12 PST by Evan Martin
Modified: 2013-01-28 10:36 PST (History)
6 users (show)

See Also:

Attachments
Patch (43.28 KB, patch)
2011-02-02 16:14 PST, Evan Martin 		no flags Details | Formatted Diff | Diff
Patch (43.39 KB, patch)
2011-02-02 16:47 PST, Evan Martin 		no flags Details | Formatted Diff | Diff
Patch (43.33 KB, patch)
2011-02-02 17:13 PST, Evan Martin 		tony: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Evan Martin 2011-02-02 16:12:03 PST 
[chromium] complex joining characters positioned in wrong place
Comment 1 Evan Martin 2011-02-02 16:14:15 PST 
Created attachment 80997 [details]
Patch
Comment 2 Evan Martin 2011-02-02 16:14:50 PST 
Tony: review.
Others: FYI
Comment 3 WebKit Review Bot 2011-02-02 16:26:28 PST 
Attachment 80997 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7689337
Comment 4 Tony Chang 2011-02-02 16:31:03 PST 
Comment on attachment 80997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80997&action=review

r- for ews bot failure

> LayoutTests/ChangeLog:12
> +        * platform/chromium-linux/fast/text/international/chromium-linux-gpos-expected.checksum: Added.
> +        * platform/chromium-linux/fast/text/international/chromium-linux-gpos-expected.png: Added.

Putting chromium-linux in the filename seems redundant.  Maybe name the test something like true-type-gpos-table.html or complex-joining-using-gpos.html?

> LayoutTests/platform/chromium-linux/fast/text/international/chromium-linux-gpos-expected.txt:20
> +          text run at (0,0) width 572: "The two words should be separated by a space, and there should be no mark above the space."

Looks like there are 3 words.

> Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp:212
> +    int scale = 64 * size * 0x10000 / platformData.emSizeInFontUnits();

Can you put 64 and 0x10000 into constants so they are less magical?
Comment 5 Evan Martin 2011-02-02 16:31:28 PST 
Crap.  Need to roll Chrome dep forward to pick up new Skia.

Good job, EWS bot!
Comment 6 Evan Martin 2011-02-02 16:47:00 PST 
Created attachment 81004 [details]
Patch
Comment 7 Evan Martin 2011-02-02 16:47:15 PST 
Comment on attachment 81004 [details]
Patch

cq- because I need to update chromium deps first
Comment 8 WebKit Review Bot 2011-02-02 16:58:38 PST 
Attachment 81004 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7694053
Comment 9 Evan Martin 2011-02-02 17:13:51 PST 
Created attachment 81008 [details]
Patch
Comment 10 Evan Martin 2011-02-03 09:49:52 PST 
Committed r77504: <http://trac.webkit.org/changeset/77504>
Comment 11 Evan Martin 2013-01-28 10:36:59 PST 
*** Bug 41435 has been marked as a duplicate of this bug. ***