Bug 53633 - gl-teximage.html failing on some WebKit bots
Summary: gl-teximage.html failing on some WebKit bots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-02 15:34 PST by Kenneth Russell
Modified: 2011-02-02 19:02 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.47 KB, patch)
2011-02-02 15:38 PST, Kenneth Russell 		mihaip: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2011-02-02 15:34:01 PST 
The layout test fast/canvas/webgl/gl-teximage.html, in particular the indexed PNG test added in https://bugs.webkit.org/show_bug.cgi?id=47477 ,  is failing on some WebKit bots. The issue appears to be that the color profile of the display is affecting the color of the PNG uploaded to WebGL.

Mihai points out that when DRT runs pixel tests (see in particular Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm, setupMainDisplayColorProfile) it loads a specific color profile for consistency of the results. This isn't occurring when running the WebGL layout tests.

This test loads and tests several other PNGs without trouble. I suspect that by stripping gamma and other colorspace information from this particular PNG that we can get consistent enough results without changing DRT to load a particular color profile even when not running pixel tests.
Comment 1 Kenneth Russell 2011-02-02 15:38:45 PST 
Created attachment 80982 [details]
Patch
Comment 2 Kenneth Russell 2011-02-02 19:02:00 PST 
Committed r77458: <http://trac.webkit.org/changeset/77458>