WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 53632
[Chromium] Option text in select popup does not align with menulist button text
https://bugs.webkit.org/show_bug.cgi?id=53632
Summary
[Chromium] Option text in select popup does not align with menulist button text
xiyuan
Reported
2011-02-02 15:24:03 PST
Created
attachment 80978
[details]
Screenshot of problem. Menulist button has addition paddings from m_innerBlock besides css paddings and PopupListBox should include those paddings as well.
Attachments
Screenshot of problem.
(2.95 KB, image/png)
2011-02-02 15:24 PST
,
xiyuan
no flags
Details
Proposed patch.
(1.65 KB, patch)
2011-02-02 15:54 PST
,
xiyuan
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
xiyuan
Comment 1
2011-02-02 15:54:52 PST
Created
attachment 80987
[details]
Proposed patch.
xiyuan
Comment 2
2011-02-02 16:18:44 PST
Comment on
attachment 80987
[details]
Proposed patch. This patch has side effect that because the m_innerBlock padding include the space for scrollbar and PopupListBox::layout might add space for scrollbar again.
xiyuan
Comment 3
2011-02-02 16:50:43 PST
Comment on
attachment 80987
[details]
Proposed patch. Resurrect the patch as we are protected from counting scrollbar width twice in RenderMenuList::clientPaddingRight which returns fixed endOfLinePadding.
Tony Chang
Comment 4
2011-02-04 09:51:57 PST
Comment on
attachment 80987
[details]
Proposed patch. View in context:
https://bugs.webkit.org/attachment.cgi?id=80987&action=review
> Source/WebCore/rendering/RenderMenuList.cpp:489 > + return paddingLeft() + m_innerBlock->paddingLeft();
Won't this change the offset for all webkit platforms? Is that intentional?
xiyuan
Comment 5
2011-02-04 10:32:13 PST
(In reply to
comment #4
)
> (From update of
attachment 80987
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=80987&action=review
> > > Source/WebCore/rendering/RenderMenuList.cpp:489 > > + return paddingLeft() + m_innerBlock->paddingLeft(); > > Won't this change the offset for all webkit platforms? Is that intentional?
This should affect Windows and Linux. Both platforms have the alignment problem. Mac probably will not be affected by this because its popup shows up via showExternal which should use native widget for the popup.
Tony Chang
Comment 6
2011-02-04 11:05:18 PST
Comment on
attachment 80987
[details]
Proposed patch. If it only affects Windows and Linux, this is fine. For reference, IE & Firefox Win aligns the text in popups. This is consistent with native menu lists on Windows. GTK+ menu lists also align the text (actually, GTK+ drop downs are like OSX menu lists where the text doesn't move but the options appear above/below the currently selected item).
WebKit Commit Bot
Comment 7
2011-02-04 18:19:56 PST
Comment on
attachment 80987
[details]
Proposed patch. Clearing flags on attachment: 80987 Committed
r77716
: <
http://trac.webkit.org/changeset/77716
>
WebKit Commit Bot
Comment 8
2011-02-04 18:20:01 PST
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 9
2011-02-04 19:29:07 PST
The commit-queue encountered the following flaky tests while processing
attachment 80987
[details]
: inspector/elements-panel-xhtml-structure.xhtml
bug 53835
(authors:
apavlov@chromium.org
and
pfeldman@chromium.org
) The commit-queue is continuing to process your patch.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug