Bug 53614 - Remove physical terminology from overflow.
Summary: Remove physical terminology from overflow.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-02 12:01 PST by Dave Hyatt
Modified: 2011-02-02 12:21 PST (History)
2 users (show)

See Also:


Attachments
Patch (41.21 KB, patch)
2011-02-02 12:02 PST, Dave Hyatt
hyatt: review-
Details | Formatted Diff | Diff
Patch (37.93 KB, patch)
2011-02-02 12:11 PST, Dave Hyatt
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2011-02-02 12:01:36 PST
Don't use top/right/bottom/left to describe overflow that is in the block's local coordinate space (which could be flipped).  Use minX/maxX/minY/maxY instead.
Comment 1 Dave Hyatt 2011-02-02 12:02:52 PST
Created attachment 80943 [details]
Patch
Comment 2 Dave Hyatt 2011-02-02 12:11:00 PST
Created attachment 80948 [details]
Patch
Comment 3 WebKit Review Bot 2011-02-02 12:14:11 PST
Attachment 80943 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7686882
Comment 4 Dave Hyatt 2011-02-02 12:19:38 PST
Fixed in r77397.
Comment 5 WebKit Review Bot 2011-02-02 12:21:05 PST
Attachment 80948 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7690160