Bug 53606 – Web Inspector: [Chromium] Landing detailed heap snapshots, part 2

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Mikhail Naganov]

Next part: displaying progress while taking a snapshot, and hints while loading and parsing. This is needed because taking detailed heap snapshots takes time.

[Mikhail Naganov]

Created attachment 80931 [details]
patch

[Pavel Feldman]

Comment on attachment 80931 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80931&action=review

> Source/WebCore/inspector/front-end/ProfilesPanel.js:451
> +        function doParse() {

{ on the next line.

[Mikhail Naganov]

Comment on attachment 80931 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80931&action=review

>> Source/WebCore/inspector/front-end/ProfilesPanel.js:451
>> +        function doParse() {
> 
> { on the next line.

Fixed.

[Mikhail Naganov]

Manually committed http://trac.webkit.org/changeset/77387

2011-02-02  Mikhail Naganov  <[e-mail]>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Landing detailed heap snapshots, part 2.

        https://bugs.webkit.org/show_bug.cgi?id=53606

        Display progress while taking a snapshot, and hints while loading
        and parsing. This is needed because taking detailed heap snapshots
        takes time.

        * English.lproj/localizedStrings.js:
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.DetailedHeapshotProfileType.prototype.buttonClicked):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype._reset):
        (WebInspector.ProfilesPanel.prototype._addProfileHeader):
        (WebInspector.ProfilesPanel.prototype.getProfiles):
        (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
        (WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
        (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
        * inspector/front-end/SidebarTreeElement.js:
        (WebInspector.SidebarTreeElement.prototype.refreshTitles):