Bug 53605 - [GTK] The GTK+ DRT needs an implementation of the PlainTextController
Summary: [GTK] The GTK+ DRT needs an implementation of the PlainTextController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-02-02 10:31 PST by Martin Robinson
Modified: 2011-04-12 17:49 PDT (History)
3 users (show)

See Also:

Attachments
Patch (14.51 KB, patch)
2011-02-03 12:30 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2011-02-02 10:31:49 PST 
There is no implementation of the PlainTextController for the GTK+ DRT, thus we fail editing/text-iterator/basic-iteration.html.
Comment 1 Martin Robinson 2011-02-03 12:30:55 PST 
Created attachment 81098 [details]
Patch
Comment 2 Martin Robinson 2011-02-03 12:31:17 PST 
I've attached an implementation of this controller.
Comment 3 Eric Seidel (no email) 2011-04-06 10:25:07 PDT 
Comment on attachment 81098 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81098&action=review

Seems sane.  It's not clear why this code can't be better shared between ports.

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:765
> +static void addControllerToWindow(JSContextRef context, JSObjectRef windowObject, const char* controllerName, JSValueRef controller)

Yay!
Comment 4 Martin Robinson 2011-04-11 16:25:23 PDT 
Committed r83530: <http://trac.webkit.org/changeset/83530>