Bug 53602 - [Chromium] Select popup with padding has white strip on right
Summary: [Chromium] Select popup with padding has white strip on right
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-02 09:40 PST by xiyuan
Modified: 2011-02-02 14:46 PST (History)
3 users (show)

See Also:


Attachments
A test case html (148 bytes, text/html)
2011-02-02 09:40 PST, xiyuan
no flags Details
Proposed patch. (1.63 KB, patch)
2011-02-02 10:06 PST, xiyuan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description xiyuan 2011-02-02 09:40:52 PST
Created attachment 80924 [details]
A test case html

http://trac.webkit.org/changeset/76831 added overhang painting to WebCore::ScrollView::paint (base of PopupListBox). The overhang is derived in ScrollView::calculateOverhangAreasForPainting based on scroll position, contentSize and visibleContentRect.

We excluded padding space from content size in PopupListBox::layout and thus the padding space is drawn as overhang.
Comment 1 xiyuan 2011-02-02 10:06:27 PST
Created attachment 80925 [details]
Proposed patch.
Comment 2 WebKit Commit Bot 2011-02-02 14:45:57 PST
Comment on attachment 80925 [details]
Proposed patch.

Clearing flags on attachment: 80925

Committed r77424: <http://trac.webkit.org/changeset/77424>
Comment 3 WebKit Commit Bot 2011-02-02 14:46:01 PST
All reviewed patches have been landed.  Closing bug.