Bug 53597 - New page created through the UI client cannot live in new context
Summary: New page created through the UI client cannot live in new context
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-02 08:45 PST by Balazs Kelemen
Modified: 2011-02-02 10:45 PST (History)
4 users (show)

See Also:


Attachments
Patch (14.63 KB, patch)
2011-02-02 10:13 PST, Balazs Kelemen
sam: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2011-02-02 08:45:02 PST
If a new page has to be created through the UI client in regard to a message sent by the WebChromeClient,
and that new page does not need to be scriptable from the current one than the client (i.e. the browser application)
may wants to create a new context for that page. An example of that situation is when the user clicks on the
"open link in new window" context menu item (and the new page's domain is different from the current one).
This possibility could make the (non-shared) secondary process model more useful.
Comment 1 Balazs Kelemen 2011-02-02 10:13:21 PST
Created attachment 80926 [details]
Patch
Comment 2 WebKit Review Bot 2011-02-02 10:15:23 PST
Attachment 80926 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/API/qt/ClientImpl.h:48:  The parameter name "page" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/UIProcess/API/qt/ClientImpl.h:48:  The parameter name "modifiers" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/UIProcess/API/qt/ClientImpl.h:48:  The parameter name "mouseButton" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2011-02-02 10:20:12 PST
Comment on attachment 80926 [details]
Patch

We are not ready to support the multiple process model at this time.  Right now we only want WebKit2 to support a single process for all the pages running in a single context.  We will be adding support for multiple processes at some point in the future.
Comment 4 Sam Weinig 2011-02-02 10:20:49 PST
Marking this as WONTFIX for now, as this is not the approach we will be taking for multiple processes when the time comes.
Comment 5 Build Bot 2011-02-02 10:45:45 PST
Attachment 80926 [details] did not build on win:
Build output: http://queues.webkit.org/results/7685940