A little more Heap refactoring
Created attachment 80894 [details] Patch
Attachment 80894 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/Android.mk', u'Sourc..." exit_code: 1 Source/JavaScriptCore/runtime/MarkedBlock.h:30: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/JavaScriptCore/runtime/MarkedBlock.h:34: BLOCK_SIZE is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MarkedBlock.h:36: BLOCK_SIZE is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MarkedBlock.h:39: BLOCK_OFFSET_MASK is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MarkedBlock.h:40: BLOCK_MASK is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MarkedBlock.h:41: MINIMUM_CELL_SIZE is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MarkedBlock.h:42: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/runtime/MarkedBlock.h:42: CELL_ARRAY_LENGTH is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MarkedBlock.h:43: CELL_SIZE is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MarkedBlock.h:44: SMALL_CELL_SIZE is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MarkedBlock.h:45: CELL_MASK is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MarkedBlock.h:46: CELL_ALIGN_MASK is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MarkedBlock.h:47: CELLS_PER_BLOCK is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MarkedBlock.h:62: The parameter name "cell" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/runtime/MarkedBlock.h:63: The parameter name "cell" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/runtime/MarkedBlock.h:64: The parameter name "cell" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/runtime/MarkedBlock.h:65: The parameter name "cell" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 17 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 80894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80894&action=review >> Source/JavaScriptCore/runtime/MarkedBlock.h:65 >> + void setMarked(JSCell* cell); > > The parameter name "cell" adds no information, so it should be removed. [readability/parameter_name] [5] You don't need the parameter names here.
Committed r77391: <http://trac.webkit.org/changeset/77391>