53566 – [v8] Increase V8 native->js recursion limit to match document.write() recursion limit

Bug 53566 - [v8] Increase V8 native->js recursion limit to match document.write() recursion limit

Summary: [v8] Increase V8 native->js recursion limit to match document.write() recursi...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Other OS X 10.5

Importance:	P2 Normal
Assignee:	James Robinson

URL:
Keywords:

Depends on:
Blocks:

Reported:	2011-02-01 18:15 PST by James Robinson
Modified:	2011-04-01 13:24 PDT (History)
CC List:	8 users (show)

See Also:

Attachments
Patch (2.68 KB, patch) 2011-02-01 18:16 PST, James Robinson	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description James Robinson 2011-02-01 18:15:00 PST

[v8] Increase V8 native->js recursion limit to match document.write() recursion limit

Comment 1 James Robinson 2011-02-01 18:16:23 PST

Created attachment 80869 [details]
Patch

Comment 2 James Robinson 2011-02-01 18:18:07 PST

This passes the test.  I would prefer to match JSC exactly here but I can't find any equivalent limit in the JSC bindings, at least at a quick glance.  Adding some people who might be familiar with the JSC bindings to see if they know of such a limit.

Comment 3 Adam Barth 2011-02-01 19:55:09 PST

Comment on attachment 80869 [details]
Patch

In crbug, you said JSC's limit was 256.  I'll leave it up to your judgement as to which number to use.  (I'd probably go with 22 absent other information.)

Comment 4 Gavin Barraclough 2011-02-01 20:04:23 PST

JSC should soon be removing its arbitrary limit in favour of checking available machine stack, so matching the current limit is probably less important.  (FWIW 22 sounds like a perfectly reasonable limit to me too!)

Comment 5 James Robinson 2011-02-01 21:13:13 PST

Comment on attachment 80869 [details]
Patch

Let's go with 22 and see what happens!

Comment 6 WebKit Commit Bot 2011-02-01 23:03:03 PST

Comment on attachment 80869 [details]
Patch

Clearing flags on attachment: 80869

Committed r77364: <http://trac.webkit.org/changeset/77364>

Comment 7 WebKit Commit Bot 2011-02-01 23:03:09 PST

All reviewed patches have been landed.  Closing bug.

Comment 8 WebKit Review Bot 2011-02-01 23:35:40 PST

http://trac.webkit.org/changeset/77364 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
http/tests/xmlhttprequest/cross-origin-no-authorization.html

Comment 9 Anna Cavender 2011-04-01 13:24:22 PDT

*** Bug 53557 has been marked as a duplicate of this bug. ***