Bug 53561 - Stepping through print previews in WebKit2 mode steps in and out of printing mode a lot
Summary: Stepping through print previews in WebKit2 mode steps in and out of printing ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Printing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-02-01 17:40 PST by Alexey Proskuryakov
Modified: 2011-02-02 10:52 PST (History)
1 user (show)

See Also:

Attachments
proposed patch (5.70 KB, patch)
2011-02-01 17:47 PST, Alexey Proskuryakov 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-02-01 17:40:27 PST 
This makes performance of stepping through print preview really bad on documents with many pages, such as <http://www.whatwg.org/specs/web-apps/current-work/>

<rdar://problem/8900228>
Comment 1 Alexey Proskuryakov 2011-02-01 17:47:39 PST 
Created attachment 80862 [details]
proposed patch
Comment 2 Sam Weinig 2011-02-01 18:35:18 PST 
Comment on attachment 80862 [details]
proposed patch

I think this would be cleaner if we added beginPrinting() endPrinting() calls to PageClient, and do the autodisplay() calls in the mac implementation of them.  What do you think?
Comment 3 Alexey Proskuryakov 2011-02-02 10:20:58 PST 
I don't like beginPrinting/endPrinting - we already have methods with these names, and they do different things, being called at a different time.

It might be better to just get a WKView (or NSWindow) pointer somehow, and have this code inside WKPrintingView, not in a page client. Not sure how to best do that, will land as is for now.
Comment 4 Alexey Proskuryakov 2011-02-02 10:52:17 PST 
Committed <http://trac.webkit.org/changeset/77386>.