Bug 53549 - Remove useless comment
Summary: Remove useless comment
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 53474
  Show dependency treegraph
 
Reported: 2011-02-01 16:21 PST by Adam Barth
Modified: 2011-02-01 21:58 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.35 KB, patch)
2011-02-01 16:31 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-02-01 16:21:25 PST
Remove useless comment
Comment 1 Adam Barth 2011-02-01 16:31:45 PST
Created attachment 80851 [details]
Patch
Comment 2 Andreas Kling 2011-02-01 16:37:25 PST
Comment on attachment 80851 [details]
Patch

Quite useless indeed.
Comment 3 WebKit Commit Bot 2011-02-01 21:13:52 PST
Comment on attachment 80851 [details]
Patch

Clearing flags on attachment: 80851

Committed r77361: <http://trac.webkit.org/changeset/77361>
Comment 4 WebKit Commit Bot 2011-02-01 21:13:57 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2011-02-01 21:37:17 PST
Actually, I found this comment extremely useful when working on this code.
Comment 6 Adam Barth 2011-02-01 21:46:14 PST
(In reply to comment #5)
> Actually, I found this comment extremely useful when working on this code.

I can't tell whether you're kidding.  Maybe we should change the true/false to be an enum?  (I couldn't have been the "no clue why" part that was useful, right?)
Comment 7 Alexey Proskuryakov 2011-02-01 21:58:05 PST
Yes, this was essentially a FIXME comment. The fact that this generic code somehow special cased a certain kind of plug-ins was worth drawing special attention for me when I looked at this function, and I was glad that Eric (I think) has added it.