Bug 53534 - Send messages when entering/exiting accelerated compositing
Summary: Send messages when entering/exiting accelerated compositing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-01 14:21 PST by Anders Carlsson
Modified: 2011-02-01 14:51 PST (History)
1 user (show)

See Also:

Attachments
Patch (15.99 KB, patch)
2011-02-01 14:22 PST, Anders Carlsson 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-02-01 14:21:09 PST 
Send messages when entering/exiting accelerated compositing
Comment 1 Anders Carlsson 2011-02-01 14:22:57 PST 
Created attachment 80828 [details]
Patch
Comment 2 WebKit Review Bot 2011-02-01 14:24:50 PST 
Attachment 80828 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/Shared/LayerTreeContext.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Roben (:aroben) 2011-02-01 14:35:01 PST 
Comment on attachment 80828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80828&action=review

> Source/WebKit2/Shared/LayerTreeContext.h:50
> +#if PLATFORM(MAC)
> +    uint32_t contextID;
> +#endif

A public data member on a class? Eww!

> Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.h:54
> +    RetainPtr<WKCARemoteLayerClientRef> m_remoteLayerRef;

Why "Ref"? How about m_remoteLayerClient?

> Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm:36
> +#import <WebKitSystemInterface.h>

Missing a WebKitSystemInterface/

> Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm:56
> +    // FIXME: Create a real layer.
> +    CALayer *layer = [CALayer layer];

Huh? How is this an unreal layer?
Comment 4 Anders Carlsson 2011-02-01 14:51:49 PST 
Committed r77315: <http://trac.webkit.org/changeset/77315>