RESOLVED FIXED 53534
Send messages when entering/exiting accelerated compositing 
https://bugs.webkit.org/show_bug.cgi?id=53534
Summary Send messages when entering/exiting accelerated compositing
Anders Carlsson
Reported 2011-02-01 14:21:09 PST
Send messages when entering/exiting accelerated compositing
Attachments
Patch (15.99 KB, patch)
2011-02-01 14:22 PST, Anders Carlsson 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-02-01 14:22:57 PST
Created attachment 80828 [details] Patch
WebKit Review Bot
Comment 2 2011-02-01 14:24:50 PST
Attachment 80828 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Shared/LayerTreeContext.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Roben (:aroben)
Comment 3 2011-02-01 14:35:01 PST
Comment on attachment 80828 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80828&action=review > Source/WebKit2/Shared/LayerTreeContext.h:50 > +#if PLATFORM(MAC) > + uint32_t contextID; > +#endif A public data member on a class? Eww! > Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.h:54 > + RetainPtr<WKCARemoteLayerClientRef> m_remoteLayerRef; Why "Ref"? How about m_remoteLayerClient? > Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm:36 > +#import <WebKitSystemInterface.h> Missing a WebKitSystemInterface/ > Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm:56 > + // FIXME: Create a real layer. > + CALayer *layer = [CALayer layer]; Huh? How is this an unreal layer?
Anders Carlsson
Comment 4 2011-02-01 14:51:49 PST
Committed r77315: <http://trac.webkit.org/changeset/77315>
Note You need to log in before you can comment on or make changes to this bug.