Remove the physical terminology from IntRect and FloatRect. Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes, we need to update our terminology to be more accurate. I'm borrowing a page from AppKit here (which also supports flipped NSViews) and renaming right() and bottom() to maxX() and maxY(). These terms remain accurate even for flipped rectangles.
Created attachment 80802 [details] Step 1: Convert most of WebCore and WebKit without getting rid of the methods yet.
Attachment 80802 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/accessibility/Accessibility..." exit_code: 1 Source/WebCore/rendering/RenderTableCell.cpp:806: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 1 in 59 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 80803 [details] Step 1: Convert most of WebCore and WebKit without getting rid of the methods yet.
Attachment 80802 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7684691
Attachment 80803 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/accessibility/Accessibility..." exit_code: 1 Source/WebCore/rendering/RenderTableCell.cpp:806: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 1 in 59 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 80804 [details] Step 1: Convert most of WebCore and WebKit without getting rid of the methods yet.
Attachment 80802 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7681828
Attachment 80803 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7685655
Created attachment 80807 [details] Step 1: Convert most of WebCore and WebKit without getting rid of the methods yet.
Attachment 80803 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7684694
Comment on attachment 80807 [details] Step 1: Convert most of WebCore and WebKit without getting rid of the methods yet. r-, still has shiftMinYEdgeTo
Created attachment 80808 [details] Step 1: Convert most of WebCore and WebKit without getting rid of the methods yet.
Comment on attachment 80808 [details] Step 1: Convert most of WebCore and WebKit without getting rid of the methods yet. Add changelogs, and watch the build bots. r=me
Attachment 80803 [details] did not build on qt: Build output: http://queues.webkit.org/results/7686565
Attachment 80804 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7682757
Attachment 80804 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7680905
Attachment 80807 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7685665
Created attachment 80812 [details] Step 1: Convert most of WebCore and WebKit without getting rid of the methods yet.
Attachment 80808 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7680907
Attachment 80803 [details] did not build on win: Build output: http://queues.webkit.org/results/7685668
Attachment 80802 [details] did not build on win: Build output: http://queues.webkit.org/results/7684706
Attachment 80804 [details] did not build on win: Build output: http://queues.webkit.org/results/7687290
Created attachment 80813 [details] Step 1: Convert most of WebCore and WebKit without getting rid of the methods yet.
Comment on attachment 80813 [details] Step 1: Convert most of WebCore and WebKit without getting rid of the methods yet. changelog! :) r=me
Step 1 landed in r77286.
Created attachment 80819 [details] Step 2: Remove the physical accessors.
Attachment 80812 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7685675
http://trac.webkit.org/changeset/77286 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, and Qt Windows 32-bit Release
Comment on attachment 80819 [details] Step 2: Remove the physical accessors. You should wait for the early warning system to tell you if you broke any ports before landing.
Attachment 80819 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7687301
Attachment 80813 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7687302
Created attachment 80823 [details] Step 2: (Reviewed by Darin, just using bots to check for errors) Remove accessors.
Attachment 80823 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7684722
Attachment 80819 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7681858
Attachment 80823 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7680948
Created attachment 80830 [details] Step 2: (Reviewed by Darin, just using bots to check for errors) Remove accessors.
Attachment 80830 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7683744
Created attachment 80837 [details] Step 2: (Reviewed by Darin, just using bots to check for errors) Remove accessors.
Attachment 80837 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7686610
Attachment 80823 [details] did not build on win: Build output: http://queues.webkit.org/results/7683761
Attachment 80837 [details] did not build on win: Build output: http://queues.webkit.org/results/7683782
Attachment 80837 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7685725
Created attachment 80864 [details] Step 2: (Reviewed by Darin, just using bots to check for errors) Remove accessors.
Attachment 80837 [details] did not build on win: Build output: http://queues.webkit.org/results/7686646
Attachment 80864 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7686650
Attachment 80864 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7689018
Attachment 80864 [details] did not build on win: Build output: http://queues.webkit.org/results/7684808
Created attachment 80878 [details] Step 2: (Reviewed by Darin, just using bots to check for errors) Remove accessors.
Attachment 80878 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7683835
Created attachment 80880 [details] Step 2: (Reviewed by Darin, just using bots to check for errors) Remove accessors.
Attachment 80880 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7682885
Attachment 80878 [details] did not build on win: Build output: http://queues.webkit.org/results/7685776
Attachment 80880 [details] did not build on win: Build output: http://queues.webkit.org/results/7685778
http://trac.webkit.org/changeset/77328(In reply to comment #25) > Step 1 landed in r77286. Qt buildfix: http://trac.webkit.org/changeset/77291 (by Hyatt) Chromium buildfix: http://trac.webkit.org/changeset/77292 (by Hyatt) Qt buildfix: http://trac.webkit.org/changeset/77300 (by Hyatt) Qt buildfix: http://trac.webkit.org/changeset/77312 (by Hyatt) Qt buildfix: http://trac.webkit.org/changeset/77316 (by Hyatt) Qt buildfix: http://trac.webkit.org/changeset/77317 (by Hyatt) Qt buildfix: http://trac.webkit.org/changeset/77328 (by me) If you had asked a Qt guy, it would have been easiear ...
Created attachment 80922 [details] Step 2: (Reviewed by Darin, just using bots to check for errors) Remove accessors.
Created attachment 80929 [details] Step 2: (Reviewed by Darin, just using bots to check for errors) Remove accessors.
Created attachment 80930 [details] Step 2: (Reviewed by Darin, just using bots to check for errors) Remove accessors.
Attachment 80929 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7685941
Attachment 80930 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7690139
Attachment 80930 [details] did not build on qt: Build output: http://queues.webkit.org/results/7691050
Fixed in r77398.
http://trac.webkit.org/changeset/77405 might have broken GTK Linux 32-bit Release The following tests are not passing: editing/selection/find-yensign-and-backslash.html http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html