Bug 53500 - Web Inspector: [Chromium] Heap snapshots are not preserved on "Back" button click when no CPU profiles gathered
Summary: Web Inspector: [Chromium] Heap snapshots are not preserved on "Back" button c...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mikhail Naganov
Depends on:
Reported: 2011-02-01 09:13 PST by Mikhail Naganov
Modified: 2011-02-01 09:23 PST (History)
10 users (show)

See Also:

patch (1.22 KB, patch)
2011-02-01 09:18 PST, Mikhail Naganov
pfeldman: review+
mnaganov: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2011-02-01 09:13:46 PST

What steps will reproduce the problem?
1. Open google.com.
2. Click "Images" link (to populate history with a same-domain link.
3. Open DevTools.
4. Gather a heap profile.
5. Click "Back" button in browser.
6. Heap profile is removed.

If before step 5 a CPU profile was also gathered, heap profile remains -- this is the correct behavior.

The fix is easy -- check if we have heap snapshots gathered the same way we are checking for CPU profiles.
Comment 1 Mikhail Naganov 2011-02-01 09:18:26 PST
Created attachment 80768 [details]
Comment 2 Mikhail Naganov 2011-02-01 09:23:28 PST
Manually committed http://trac.webkit.org/changeset/77254

    2011-02-01  Mikhail Naganov  <mnaganov@chromium.org>
            Reviewed by Pavel Feldman.
            Web Inspector: Fix profiles reset to avoid clearing heap profiles in Chromium.
            * inspector/InspectorProfilerAgent.cpp: