Bug 53493 - DevTools: assertion failure upon devtools window reopen.
Summary: DevTools: assertion failure upon devtools window reopen.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vivek Galatage
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-01 08:02 PST by Pavel Feldman
Modified: 2012-04-19 12:13 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.39 KB, patch)
2012-04-19 05:30 PDT, Vivek Galatage
no flags Details | Formatted Diff | Diff
Patch (1.37 KB, patch)
2012-04-19 05:37 PDT, Vivek Galatage
no flags Details | Formatted Diff | Diff
Patch (1.90 KB, patch)
2012-04-19 11:30 PDT, Vivek Galatage
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-02-01 08:02:15 PST
Patch to follow.
Comment 1 Vivek Galatage 2012-04-19 05:09:10 PDT
Pavel, if it is ok with you, I have a patch for the bug and I can upload the same for your review.
Comment 2 Vivek Galatage 2012-04-19 05:17:53 PDT
in method WebInspectorClientFrontend::closeWindow() should explicitly call m_page->inspector()->destroyInspectorPage(); in order to reset the pointers.
Comment 3 Vivek Galatage 2012-04-19 05:30:05 PDT
Created attachment 137882 [details]
Patch
Comment 4 Vivek Galatage 2012-04-19 05:37:05 PDT
Created attachment 137883 [details]
Patch
Comment 5 Pavel Feldman 2012-04-19 09:10:06 PDT
Comment on attachment 137883 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137883&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:75
> +    m_page->inspector()->destroyInspectorPage();

It sounds like you should inline destroyInspectorPage into didClose in the WebInspector instead.
Comment 6 Vivek Galatage 2012-04-19 11:30:06 PDT
Created attachment 137932 [details]
Patch
Comment 7 WebKit Review Bot 2012-04-19 12:12:59 PDT
Comment on attachment 137932 [details]
Patch

Clearing flags on attachment: 137932

Committed r114665: <http://trac.webkit.org/changeset/114665>
Comment 8 WebKit Review Bot 2012-04-19 12:13:03 PDT
All reviewed patches have been landed.  Closing bug.