Bug 53487 – [Gtk] No need to set text encoding in the provisional phase

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Joone Hur]

After loading a html document, other ports initialize the encoding setting, but WebKitGtk+ sets the same encoding again, even tries to set encoding in the provisional phase. This causes unnecessary encoding setting.

Please, take a look at the following code.
http://trac.webkit.org/browser/trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp#L626
http://trac.webkit.org/browser/trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp#L1028

This patch allows to skip the encoding setting in the cases like other ports such as Mac and Qt.

[Joone Hur]

Created attachment 80748 [details]
Proposed Patch

[Martin Robinson]

 I recall looking at this issue briefly, but at this point I no longer remember why our implementation differs from Qt. Does this allow us to unskip any tests?j

[Joone Hur]

(In reply to comment #2)
>  I recall looking at this issue briefly, but at this point I no longer remember why our implementation differs from Qt. Does this allow us to unskip any tests?j

I tried to find any tests to be unskipped, but I couldn't find them.
Actually, there seems to be no problem without this patch until now, but I'm sure that this patch allows WebKitGtk+ to work like other ports. This may prevent unexpected errors.

[Joone Hur]

Created attachment 81057 [details]
Proposed Patch2

I added more details.

[Martin Robinson]

Comment on attachment 81057 [details]
Proposed Patch2

Thank you!

[WebKit Commit Bot]

Comment on attachment 81057 [details]
Proposed Patch2

Clearing flags on attachment: 81057

Committed r77596: <http://trac.webkit.org/changeset/77596>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.