RESOLVED FIXED 53478
Refactor JSGlobalObject-related tear-down 
https://bugs.webkit.org/show_bug.cgi?id=53478
Summary Refactor JSGlobalObject-related tear-down
Geoffrey Garen
Reported 2011-02-01 00:07:38 PST
Fixed some crashes seen on the WebKit2 buildbot
Attachments
Patch (14.62 KB, patch)
2011-02-01 00:31 PST, Geoffrey Garen 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2011-02-01 00:31:47 PST
Created attachment 80725 [details] Patch
Geoffrey Garen
Comment 2 2011-02-01 08:25:59 PST
Looking at this further, I think the patch here is a good refactoring, but it doesn't seem to fix the underlying cause of these crashes. The cause seems to be, not objects relying on destructor order, but objects not having their destructors run at all.
Geoffrey Garen
Comment 3 2011-02-01 11:41:31 PST
Retitling since this patch doesn't seem to fully fix the WebKit2 bot regression, but I'd still like to land it on its own. I'm going to wait to land this until the regressions are sorted out, since this patch seems to cover them up somewhat.
Geoffrey Garen
Comment 4 2011-02-01 21:10:49 PST
Committed r77360: <http://trac.webkit.org/changeset/77360>
Note You need to log in before you can comment on or make changes to this bug.