Bug 53472 - Clean up ShadowBlur
Summary: Clean up ShadowBlur
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-31 21:05 PST by Simon Fraser (smfr)
Modified: 2011-01-31 21:33 PST (History)
2 users (show)

See Also:

Attachments
Patch (14.20 KB, patch)
2011-01-31 21:10 PST, Simon Fraser (smfr) 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2011-01-31 21:05:58 PST 
Clean up ShadowBlur
Comment 1 Simon Fraser (smfr) 2011-01-31 21:10:39 PST 
Created attachment 80714 [details]
Patch
Comment 2 Sam Weinig 2011-01-31 21:18:01 PST 
Comment on attachment 80714 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80714&action=review

> Source/WebCore/platform/graphics/ShadowBlur.cpp:427
> +    shadowContext->setFillColor(Color(.0f, .0f, .0f, 1.f), ColorSpaceDeviceRGB);

This doesn't need to use the float Color constructor anymore.

> Source/WebCore/platform/graphics/ShadowBlur.cpp:487
> +    shadowContext->setFillColor(Color(.0f, .0f, .0f, 1.f), ColorSpaceDeviceRGB);

Nor here.
Comment 3 Simon Fraser (smfr) 2011-01-31 21:20:17 PST 
http://trac.webkit.org/changeset/77213
Comment 4 Simon Fraser (smfr) 2011-01-31 21:33:37 PST 
And http://trac.webkit.org/changeset/77215