Bug 53467 - Update JSObject storage for new marking API
Summary: Update JSObject storage for new marking API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-31 18:23 PST by Oliver Hunt
Modified: 2011-02-01 12:17 PST (History)
2 users (show)

See Also:


Attachments
Patch (39.47 KB, patch)
2011-01-31 18:26 PST, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (40.26 KB, patch)
2011-02-01 10:03 PST, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (40.33 KB, patch)
2011-02-01 11:13 PST, Oliver Hunt
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-01-31 18:23:42 PST
Update JSObject storage for new marking API
Comment 1 Oliver Hunt 2011-01-31 18:26:37 PST
Created attachment 80704 [details]
Patch
Comment 2 Build Bot 2011-01-31 19:00:05 PST
Attachment 80704 [details] did not build on win:
Build output: http://queues.webkit.org/results/7687078
Comment 3 Geoffrey Garen 2011-01-31 20:10:01 PST
Comment on attachment 80704 [details]
Patch

LGTM but you gots to fix the windows build.
Comment 4 Oliver Hunt 2011-01-31 22:32:31 PST
(In reply to comment #3)
> (From update of attachment 80704 [details])
> LGTM but you gots to fix the windows build.
i know but needed ews ot tel me the symbol :)
Comment 5 Oliver Hunt 2011-02-01 10:03:31 PST
Created attachment 80778 [details]
Patch
Comment 6 Oliver Hunt 2011-02-01 10:12:23 PST
Comment on attachment 80778 [details]
Patch

Will probably need one more revision to get windows ubild fixed
Comment 7 Build Bot 2011-02-01 11:02:59 PST
Attachment 80778 [details] did not build on win:
Build output: http://queues.webkit.org/results/7687238
Comment 8 Oliver Hunt 2011-02-01 11:13:50 PST
Created attachment 80790 [details]
Patch
Comment 9 WebKit Review Bot 2011-02-01 11:26:36 PST
Attachment 80704 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/runtime/BooleanObject.h:30:  The parameter name "globalData" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Geoffrey Garen 2011-02-01 11:38:44 PST
Comment on attachment 80790 [details]
Patch

r=me
Comment 11 WebKit Review Bot 2011-02-01 11:58:43 PST
Attachment 80778 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/runtime/BooleanObject.h:30:  The parameter name "globalData" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 WebKit Review Bot 2011-02-01 12:06:08 PST
Attachment 80790 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/runtime/BooleanObject.h:30:  The parameter name "globalData" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 Oliver Hunt 2011-02-01 12:17:42 PST
Committed r77269: <http://trac.webkit.org/changeset/77269>