Bug 53448 - Some favicons not correctly decoded by Chromium/Mac
Summary: Some favicons not correctly decoded by Chromium/Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) OS X 10.6
: P2 Normal
Assignee: Matthew Vosburgh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-31 13:01 PST by Matthew Vosburgh
Modified: 2011-02-02 12:26 PST (History)
1 user (show)

See Also:

Attachments
Use the same frame selection logic as the WebImageSkia code, rather than just picking frame[0]. (2.00 KB, patch)
2011-01-31 13:31 PST, Matthew Vosburgh 		no flags Details | Formatted Diff | Diff
Patch (2.56 KB, patch)
2011-02-02 12:23 PST, Kenneth Russell 		kbr: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Vosburgh 2011-01-31 13:01:11 PST 
What steps will reproduce the problem?
1. Bookmark "www.frys.com" in a Chromium-based browser.

Actual: No favicon show up. It is blank.
Expected: Show Favicon. 

See chromium bug http://code.google.com/p/chromium/issues/detail?id=34797

The code responsible is Mac/Chromium specific code in the WebKit tree, specifically in WebKit/chromium/src/WebImageCG.cpp.
The fix is to change the implementation of WebImage::fromData() to be more discriminating, using equivalent code to the WebImageSkia implementation.
Comment 1 Matthew Vosburgh 2011-01-31 13:31:32 PST 
Created attachment 80674 [details]
Use the same frame selection logic as the WebImageSkia code, rather than just picking frame[0].
Comment 2 Kenneth Russell 2011-02-02 12:23:53 PST 
Created attachment 80949 [details]
Patch
Comment 3 Kenneth Russell 2011-02-02 12:24:43 PST 
Re-indented patch for maf and provided ChangeLog entry. Verified fix manually in Chromium.
Comment 4 Kenneth Russell 2011-02-02 12:25:14 PST 
Comment on attachment 80949 [details]
Patch

Looks fine. Verified fix in Chromium.
Comment 5 Kenneth Russell 2011-02-02 12:26:15 PST 
Committed r77400: <http://trac.webkit.org/changeset/77400>