Bug 53432 - Make LayerTreeHost an abstract base class and make LayerTreeHostMac inherit from it
Summary: Make LayerTreeHost an abstract base class and make LayerTreeHostMac inherit f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-31 09:54 PST by Anders Carlsson
Modified: 2011-01-31 10:08 PST (History)
0 users

See Also:

Attachments
Patch (13.47 KB, patch)
2011-01-31 09:58 PST, Anders Carlsson 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-01-31 09:54:58 PST 
Make LayerTreeHost an abstract base class and make LayerTreeHostMac inherit from it
Comment 1 Anders Carlsson 2011-01-31 09:58:03 PST 
Created attachment 80651 [details]
Patch
Comment 2 Adam Roben (:aroben) 2011-01-31 10:02:44 PST 
Comment on attachment 80651 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80651&action=review

Maybe WebPorcess/WebPage/ca/LayerTreeHostCA.mm would be more appropriate?

> Source/WebKit2/WebProcess/WebPage/LayerTreeHost.cpp:47
> +    return adoptPtr(static_cast<LayerTreeHost*>(new LayerTreeHostMac(webPage, graphicsLayer)));

Is the cast really needed here?
Comment 3 Anders Carlsson 2011-01-31 10:08:15 PST 
Committed r77139: <http://trac.webkit.org/changeset/77139>