Bug 53408 - Fixed crash on window close (maybe crash on launch?) due to missing frame null checks
Summary: Fixed crash on window close (maybe crash on launch?) due to missing frame nul...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-30 19:23 PST by Geoffrey Garen
Modified: 2011-01-30 20:06 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.79 KB, patch)
2011-01-30 19:24 PST, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (3.15 KB, patch)
2011-01-30 20:03 PST, Geoffrey Garen 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-01-30 19:23:38 PST 
Fixed crash on launch / crash on window close due to missing frame null checks
Comment 1 Geoffrey Garen 2011-01-30 19:24:35 PST 
Created attachment 80612 [details]
Patch
Comment 2 Maciej Stachowiak 2011-01-30 19:34:12 PST 
Comment on attachment 80612 [details]
Patch

r=me
Comment 3 Geoffrey Garen 2011-01-30 19:36:14 PST 
Committed r77102: <http://trac.webkit.org/changeset/77102>
Comment 4 Geoffrey Garen 2011-01-30 19:37:38 PST 
Maciej mentioned on IRC that it was surprising that the process ever got into this state.

It happened on a system that was crawling due to massive paging, possibly after a web process crash. I speculate that it was a race condition related to exiting / crashing.
Comment 5 Geoffrey Garen 2011-01-30 20:01:34 PST 
Sam said on IRC that this should be an ASSERT and not a null check, since we should not get into this state.
Comment 6 Geoffrey Garen 2011-01-30 20:03:54 PST 
Created attachment 80616 [details]
Patch
Comment 7 Geoffrey Garen 2011-01-30 20:06:50 PST 
Committed r77104: <http://trac.webkit.org/changeset/77104>