Bug 53402 - Add sanity check to help diagnose bug 52819
Summary: Add sanity check to help diagnose bug 52819
Alias: None
Product: WebKit
Classification: Unclassified
Component: History (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 52819
  Show dependency treegraph
Reported: 2011-01-30 12:58 PST by Charles Reis
Modified: 2011-01-31 20:04 PST (History)
2 users (show)

See Also:

Patch (1.66 KB, patch)
2011-01-30 13:05 PST, Charles Reis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Reis 2011-01-30 12:58:01 PST
We're seeing many crash reports for bug 52819 in HistoryController::itemsAreClones.  The crashes happen when fromItem in recursiveSetProvisionalItem is null, which happens if the parent HistoryItem does not have a child item with the target frame name.

The crash reports suggest that fromItem has 0 children, which should be impossible.  (The previous call to itemsAreClones should verify that fromItem and item have the same number of children, and item clearly has children.)  On the flip side, it's possible for the crash to happen if fromItem has ended up with two children of the same name, though the crash reports don't seen to be consistent with that.

This bug is for adding a sanity check to help diagnose which (if either) of these is happening in practice, since we don't have any information about how to reproduce the crash yet.
Comment 1 Charles Reis 2011-01-30 13:05:12 PST
Created attachment 80599 [details]
Comment 2 WebKit Commit Bot 2011-01-31 20:04:29 PST
Comment on attachment 80599 [details]

Clearing flags on attachment: 80599

Committed r77210: <http://trac.webkit.org/changeset/77210>
Comment 3 WebKit Commit Bot 2011-01-31 20:04:33 PST
All reviewed patches have been landed.  Closing bug.