Bug 53399 - FindController::updateFindIndicator() crashes if selection isn't visible
Summary: FindController::updateFindIndicator() crashes if selection isn't visible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P1 Critical
Assignee: Jeff Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-30 09:54 PST by Jeff Miller
Modified: 2011-01-31 07:28 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.52 KB, patch)
2011-01-30 10:11 PST, Jeff Miller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Miller 2011-01-30 09:54:35 PST
1. Goto www.google.com in Safari.
2. Type Ctrl+F to bring up find in page.
3. Search for "goo".  This results in 3 matches, only 2 of which are visible.
4. Hit F3, F3, F3 to go to the third, invisible match.
5. WebKit process crashes.
Comment 1 Jeff Miller 2011-01-30 10:11:01 PST
Created attachment 80595 [details]
Patch
Comment 2 mitz 2011-01-30 10:15:54 PST
Comment on attachment 80595 [details]
Patch

Is there a way to make an API test for this?
Comment 3 Jeff Miller 2011-01-30 10:34:33 PST
It seems like this should be possible with some changes to Tools/TestWebKitAPI/Tests/WebKit2/Find.cpp and Find.html, I'll look into this.
Comment 4 WebKit Commit Bot 2011-01-30 12:04:54 PST
Comment on attachment 80595 [details]
Patch

Clearing flags on attachment: 80595

Committed r77091: <http://trac.webkit.org/changeset/77091>
Comment 5 WebKit Commit Bot 2011-01-30 12:04:58 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Steve Falkenburg 2011-01-30 14:00:54 PST
Ignore my r+
looks like this was already fixed.