Bug 53370 - XSSFilter should replace URLs with about:blank instead of the empty string
Summary: XSSFilter should replace URLs with about:blank instead of the empty string
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 49845
  Show dependency tree / graph
 
Reported: 2011-01-28 23:47 PST by Adam Barth
Modified: 2011-01-29 03:43 PST (History)
10 users (show)

See Also:

Attachments
Patch (1.97 KB, patch)
2011-01-28 23:48 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-01-28 23:47:57 PST 
XSSFilter should replace URLs with about:blank instead of the empty string
Comment 1 Adam Barth 2011-01-28 23:48:52 PST 
Created attachment 80552 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2011-01-28 23:52:53 PST 
Attachment 80552 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7567446
Comment 3 WebKit Review Bot 2011-01-28 23:52:59 PST 
Attachment 80552 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7679063
Comment 4 Early Warning System Bot 2011-01-29 00:01:31 PST 
Attachment 80552 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7679065
Comment 5 Adam Barth 2011-01-29 00:10:08 PST 
This patch builds fine.  It just depends on patches earlier in the sequence.
Comment 6 Build Bot 2011-01-29 00:15:45 PST 
Attachment 80552 [details] did not build on win:
Build output: http://queues.webkit.org/results/7582428
Comment 7 WebKit Review Bot 2011-01-29 00:35:01 PST 
Attachment 80552 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7679072
Comment 8 Adam Barth 2011-01-29 01:22:37 PST 
Comment on attachment 80552 [details]
Patch

Clearing flags on attachment: 80552

Committed r77060: <http://trac.webkit.org/changeset/77060>
Comment 9 Adam Barth 2011-01-29 01:22:41 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 WebKit Review Bot 2011-01-29 03:43:09 PST 
http://trac.webkit.org/changeset/77060 might have broken GTK Linux 64-bit Debug