Bug 53368 - Fix XSSFilter crash when extracting the source for a token twice
Summary: Fix XSSFilter crash when extracting the source for a token twice
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 49845
  Show dependency tree / graph
 
Reported: 2011-01-28 23:21 PST by Adam Barth
Modified: 2011-01-29 18:40 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.96 KB, patch)
2011-01-28 23:30 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-01-28 23:21:09 PST 
Fix XSSFilter crash when extracting the source for a token twice
Comment 1 Adam Barth 2011-01-28 23:30:25 PST 
Created attachment 80551 [details]
Patch
Comment 2 Adam Barth 2011-01-28 23:31:27 PST 
BTW, after this patch, we pass all the xssAuditor/script-tag* tests!
Comment 3 Daniel Bates 2011-01-29 15:27:12 PST 
Comment on attachment 80551 [details]
Patch

This looks sane to me.

r=me.
Comment 4 Daniel Bates 2011-01-29 15:27:31 PST 
(In reply to comment #2)
> BTW, after this patch, we pass all the xssAuditor/script-tag* tests!

Awesome!
Comment 5 Adam Barth 2011-01-29 17:21:27 PST 
Comment on attachment 80551 [details]
Patch

Thanks Dan!
Comment 6 WebKit Commit Bot 2011-01-29 18:40:00 PST 
Comment on attachment 80551 [details]
Patch

Clearing flags on attachment: 80551

Committed r77076: <http://trac.webkit.org/changeset/77076>
Comment 7 WebKit Commit Bot 2011-01-29 18:40:04 PST 
All reviewed patches have been landed.  Closing bug.