Bug 53366 – REGRESSION (r72141): ClickToFlash Safari extension misrendered

• Status: RESOLVED
• Resolution: INVALID
• Component: New Bugs

[Jon]

Under ToT and the r76727 nightly, the plugin activation overlay is rendered incorrectly. The plugin label (Flash, Silverlight, etc.) is supposed to render in the center of the filler, but is currently rendering perhaps 20 pixels too low. It renders correctly in Safari 5.0.3 and can be seen on the extension's site, linked in the URL field.

[Alexey Proskuryakov]

<rdar://problem/8935841>

[Andy Estes]

This is a change in behavior from <http://trac.webkit.org/changeset/72141>, although I hesitate to call it a regression since that change fixed buggy font-size behavior which ClickToFlash might have been relying on. Perhaps it would be easier to have the developer fix this issue with an extensions update. A reduced test case would be nice in any case.

[Marc Hoyois]

The problem is that the computed value of "height" for the text "Flash" is 0, while the rules that apply are height: auto and font-size: 20px. Is there any reason this should happen? I did try a very reduced test a couple weeks ago and this did NOT happen, so I think it's a bug. I'll try to come up with a working reduced test case asap. One weird thing I noticed is that the font-size rule is struck through in the web inspector, even though it has precedence and is indeed used for the computed style.

[Marc Hoyois]

Ooh, I didn't see there's a line-height:0 that also applies. That's probably where the nightlies differ from the current Safari. The overall vertical padding is 21px and the height between the interior of the borders is 28px in the current Safari, so it adds 7px for the line-height:0 text. Webkit has a displayed height of 21px, so I guess this is correct after all.

[Marc Hoyois]

Using line-height:1 makes all versions of Safari behave in the same way. I'll update the extension and the status of this can probably be changed to INVALID.

[Andy Estes]

Thanks Marc!